-
Notifications
You must be signed in to change notification settings - Fork 72
refactor: Changed paths for lens migration in CLI #3510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3510 +/- ##
===========================================
+ Coverage 78.48% 78.55% +0.08%
===========================================
Files 397 397
Lines 37599 37599
===========================================
+ Hits 29506 29535 +29
+ Misses 6400 6379 -21
+ Partials 1693 1685 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
AndrewSisley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Chris, maybe keep this one open a few more hours if it isn't blocking you in case anyone has any strong opinions.
I don't really mind which direction this is changed in, but do prefer that http and cli are aligned.
fredcarle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for making this set of command align with the HTTP handlers.
## Relevant issue(s) Resolves sourcenetwork#2291 ## Description The following commands were currently in the CLI: defradb client schema migration down defradb client schema migration reload defradb client schema migration set defradb client schema migration set-registry defradb client schema migration up With these changes, they instead become: defradb client lens down defradb client lens reload defradb client lens set defradb client lens set-registry defradb client lens up This brings them more in line with how they are named in the Http client. ## Tasks - [x] I made sure the code is well commented, particularly hard-to-understand areas. - [x] I made sure the repository-held documentation is changed accordingly. - [x] I made sure the pull request title adheres to the conventional commit style (the subset used in the project can be found in [tools/configs/chglog/config.yml](tools/configs/chglog/config.yml)). - [x] I made sure to discuss its limitations such as threats to validity, vulnerability to mistake and misuse, robustness to invalidation of assumptions, resource requirements, ... ## How has this been tested? Specify the platform(s) on which this was tested: - Windows
Relevant issue(s)
Resolves #2291
Description
The following commands were currently in the CLI:
defradb client schema migration down
defradb client schema migration reload
defradb client schema migration set
defradb client schema migration set-registry
defradb client schema migration up
With these changes, they instead become:
defradb client lens down
defradb client lens reload
defradb client lens set
defradb client lens set-registry
defradb client lens up
This brings them more in line with how they are named in the Http client.
Tasks
How has this been tested?
Specify the platform(s) on which this was tested: