fix: Updating of document via cli #3474
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3474 +/- ##
===========================================
+ Coverage 78.31% 78.40% +0.09%
===========================================
Files 397 397
Lines 37571 37574 +3
===========================================
+ Hits 29423 29459 +36
+ Misses 6439 6416 -23
+ Partials 1709 1699 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
8e5665f to
54c679e
Compare
AndrewSisley
left a comment
There was a problem hiding this comment.
LGTM, thanks Islam!
| SupportedClientTypes: immutable.Some( | ||
| []testUtils.ClientType{testUtils.HTTPClientType, testUtils.CLIClientType}), | ||
| Actions: []any{ | ||
| testUtils.UpdateWithFilter{ |
There was a problem hiding this comment.
praise: I forgot we had this, thanks for using it and not doing whatever I suggested in the standup 😁 Thanks for the comment too, it explains it nicely.
## Relevant issue(s) Resolves sourcenetwork#3470 ## Description Make `client collection update` always expect `--updater` parameter. Change filter expectation from `{ "_gte": { "points": 100 } }` to `'{ "points": { "_gte": 100 } }` Make db expect filter param as `map[string]any`.
Relevant issue(s)
Resolves #3470
Description
Make
client collection updatealways expect--updaterparameter.Change filter expectation from
{ "_gte": { "points": 100 } }to'{ "points": { "_gte": 100 } }Make db expect filter param as
map[string]any.