test: Remove hardcoded test identities #2822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2822 +/- ##
===========================================
- Coverage 79.14% 78.97% -0.17%
===========================================
Files 318 318
Lines 24162 24162
===========================================
- Hits 19122 19081 -41
- Misses 3663 3690 +27
- Partials 1377 1391 +14
Flags with carried forward coverage won't be shown. Click here to find out more. see 16 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
cafd0f2 to
2436eaa
Compare
2436eaa to
8d341fc
Compare
nasdf
reviewed
Jul 9, 2024
| Actions: []any{ | ||
| testUtils.AddPolicy{ | ||
| Identity: actor1Identity, | ||
| Identity: immutable.Some(1), |
Member
There was a problem hiding this comment.
question: why use index 1 if we never use index 0?
Contributor
Author
There was a problem hiding this comment.
I didn't think that hard about it :) actor*1*Identity => ID(1). I don't think this is important.
Member
There was a problem hiding this comment.
Okay that makes sense. I thought there might be something else I'm missing.
ChrisBQu
pushed a commit
to ChrisBQu/defradb
that referenced
this pull request
Feb 21, 2025
## Relevant issue(s) Resolves sourcenetwork#2821 ## Description Removes the hardcoded test identities from our integration tests. The current (develop) setup becomes impossible with source-hub ACP as the identity needs to include a signed bearer token containing the sourcehub address (not accessible during package init). I also think this is a bit more maintainable.
ChrisBQu
pushed a commit
to ChrisBQu/defradb
that referenced
this pull request
Apr 25, 2025
## Relevant issue(s) Resolves sourcenetwork#2821 ## Description Removes the hardcoded test identities from our integration tests. The current (develop) setup becomes impossible with source-hub ACP as the identity needs to include a signed bearer token containing the sourcehub address (not accessible during package init). I also think this is a bit more maintainable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2821
Description
Removes the hardcoded test identities from our integration tests.
The current (develop) setup becomes impossible with source-hub ACP as the identity needs to include a signed bearer token containing the sourcehub address (not accessible during package init).
I also think this is a bit more maintainable.
This commit has been broken out of #2657 to minimize the risk of conflicts and to keep the PRs focused. It might be useful for reviewers to have a quick look at the full (WIP)
getIdentityfunc in the original PR.