Skip to content

Conversation

@AndrewSisley
Copy link
Contributor

@AndrewSisley AndrewSisley commented Jun 28, 2024

Relevant issue(s)

Resolves #2620

Description

Support one-many self joins without primary directive.

@AndrewSisley AndrewSisley added bug Something isn't working area/schema Related to the schema system labels Jun 28, 2024
@AndrewSisley AndrewSisley added this to the DefraDB v0.12 milestone Jun 28, 2024
@AndrewSisley AndrewSisley requested a review from a team June 28, 2024 17:28
@AndrewSisley AndrewSisley self-assigned this Jun 28, 2024
@AndrewSisley AndrewSisley force-pushed the 2620-self-without-primary branch from 18947dd to 53a74a4 Compare June 28, 2024 17:28
Copy link
Collaborator

@fredcarle fredcarle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndrewSisley AndrewSisley force-pushed the 2620-self-without-primary branch 2 times, most recently from 7774780 to 15ab95f Compare June 28, 2024 18:43
@AndrewSisley AndrewSisley force-pushed the 2620-self-without-primary branch from 15ab95f to 4447999 Compare June 28, 2024 19:19
@codecov
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.78%. Comparing base (1f9c3ee) to head (4447999).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2799      +/-   ##
===========================================
- Coverage    78.85%   78.78%   -0.06%     
===========================================
  Files          315      315              
  Lines        23836    23836              
===========================================
- Hits         18794    18779      -15     
- Misses        3667     3678      +11     
- Partials      1375     1379       +4     
Flag Coverage Δ
all-tests 78.78% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/request/graphql/schema/collection.go 90.35% <100.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f9c3ee...4447999. Read the comment docs.

@AndrewSisley AndrewSisley merged commit aaaa9d9 into sourcenetwork:develop Jun 28, 2024
@AndrewSisley AndrewSisley deleted the 2620-self-without-primary branch June 28, 2024 19:55
ChrisBQu pushed a commit to ChrisBQu/defradb that referenced this pull request Feb 21, 2025
…work#2799)

## Relevant issue(s)

Resolves sourcenetwork#2620

## Description

Support one-many self joins without primary directive.
ChrisBQu pushed a commit to ChrisBQu/defradb that referenced this pull request Apr 25, 2025
…work#2799)

## Relevant issue(s)

Resolves sourcenetwork#2620

## Description

Support one-many self joins without primary directive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/schema Related to the schema system bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

One-many self joins fail without explicit @primary directive

2 participants