feat: Enable sec. indexes with ACP #2602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredcarle
approved these changes
May 9, 2024
Collaborator
fredcarle
left a comment
There was a problem hiding this comment.
LGTM. I was surprised to see that it already works and all you had to do was allow the creation of the index. 👍
| testUtils.AddPolicy{ | ||
| Identity: acpUtils.Actor1Identity, | ||
| Policy: userPolicy, | ||
| ExpectedPolicyID: "53980e762616fcffbe76307995895e862f87ef3f21d509325d1dc772a770b001", |
Collaborator
There was a problem hiding this comment.
suggestion: It would be nice to add the policy ID above the policy definition as a comment for future reference. Like if someone what's to use it elsewhere it would be easy for them to quickly grab it.
shahzadlone
pushed a commit
that referenced
this pull request
May 14, 2024
## Relevant issue(s) Resolves #2365 ## Description Enable secondary indexes with ACP.
ChrisBQu
pushed a commit
to ChrisBQu/defradb
that referenced
this pull request
Feb 21, 2025
## Relevant issue(s) Resolves sourcenetwork#2365 ## Description Enable secondary indexes with ACP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2365
Description
Enable secondary indexes with ACP.