fix: Return correct results from one-many indexed filter #2579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is annoying to have to keep commenting bits out in order to test one thing, now (ignoring explain) we can test one thing at a time.
So that I can read it, and adjust it to what is under test. I don't know what the original test data was, so it has also been adjusted in this commit.
Like the multi-query test function, having to comment out the explain query in order to test one thing at a time is annoying.
c8ef61c to
84e92c5
Compare
fredcarle
approved these changes
May 3, 2024
Collaborator
fredcarle
left a comment
There was a problem hiding this comment.
LGTM! Thanks for fixing this and the added tests.
ChrisBQu
pushed a commit
to ChrisBQu/defradb
that referenced
this pull request
Feb 21, 2025
…rk#2579) ## Relevant issue(s) Resolves sourcenetwork#2574 ## Description Return correct results from one-many joins filtered on an indexed field on the many side. The invertibleTypeJoin doesn't support the inversion of one-many joins and was converting them into one-one joins. This means that the index is no longer used if targeting the many side: sourcenetwork#2578 (this support can be added after the release).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #2574
Description
Return correct results from one-many joins filtered on an indexed field on the many side.
The invertibleTypeJoin doesn't support the inversion of one-many joins and was converting them into one-one joins.
This means that the index is no longer used if targeting the many side: #2578 (this support can be added after the release).