Allow passing JVM argsto javac in ScipBuildTool #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javac cannot extract -J flags from the argfile because these flags need to be passed to the launcher, which is already running by the time the argfile comes into play. See https://docs.oracle.com/en/java/javase/17/docs/specs/man/javac.html#command-line-argument-files for reference.
olafurpg
approved these changes
Aug 1, 2024
Contributor
olafurpg
left a comment
There was a problem hiding this comment.
This makes a lot of sense. LGTM 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A canonical usage for this is passing
--add-opensflags to the launcher of javac to make sure annotation processors work.To pass these arguments to the launcher, they have to be perfixed with -J – but arguments like this cannot be passed through the argfile that we use for javacOptions (see https://docs.oracle.com/en/java/javase/17/docs/specs/man/javac.html#command-line-argument-files) so we need to pass them to the command itself.
For that purpose, we add a
jvmOptionsfield to scip-java.json config – these options will have-Jadded to them and passed to thejavaccommand.The test to verify this behaviour relies on an old version of lombok that requires these options
Additionally, a hidden option
--strict-compilationis added to the CLI, to prevent error recovery: sometimes scip-java can just ignore javac errors and produce semanticdb artifacts regardless. This complicates testing, so I need an escape hatch).Test plan