bundle solid-start/entry-client
#1034
Conversation
3793427
to
d61d9d9
Compare
| declare global { | ||
| interface Window { | ||
| router: { | ||
| navigate: (to: string, options?: Partial<NavigateOptions>) => Promise<boolean>; | ||
| push: (to: string | URL, options: Partial<NavigateOptions>) => void; | ||
| update: (body: string) => Promise<boolean>; | ||
| router: EventTarget; | ||
| location: () => LocationEntry; | ||
| }; | ||
| } | ||
| interface StartRoutes { | ||
| $: { | ||
| params: any; | ||
| data: any; | ||
| }; | ||
| } | ||
| interface Route { | ||
| "/notes/[note]": "/notes/[note]"; | ||
| } | ||
| } |
There was a problem hiding this comment.
This file was generated from Router.tsx. It's used by the tsconfig via "types": [ ..., "solid-start/router", which afaik only accepts .d.ts files (or whole projects).
In actuality all entry-client needs is this here declare global, but I'm leaving it in Router.tsx for now for easy review. Could easily move it elsewhere if requested!
This reverts commit 3efacdd.
since they're in the base tsconfig, which is extended by `entry-client/tsconfig.json`
| { | ||
| "name": "solid-start/entry-client", | ||
| "module": "./dist/index.jsx", | ||
| "types": "./dist/index.d.ts", | ||
| "type": "module", | ||
| "sideEffects": false | ||
| } |
There was a problem hiding this comment.
I'm not including main because I believe we require Node18.... I don't know nearly enough about Node to know if that's good enough justification but we're not using a "real" bundler like Rollup. Maybe later?
|
Truthfully.. we're sort of completely changing all of this in 0.4.. like completely changing the entry imports etc.. so I will take this under consideration but no action at the moment. |
|
Coolbeans, more than happy to make PRs if/when you get to that point! |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Solid-Start is distributed as Typescript, leading to issues like #1008 and #255 This is not recommended.
What is the new behavior?
This PR creates a new
solid-start/entry-client"package", similar toweb,store,h, etc. in SolidJS. (Really I just looked at SolidJS and was like ctrl-c ctrl-v.) I only didentry-clientfor now to solicit feedback - I imagine the other folders of start to be more or less the same type of change. If the maintainers approve, I'll do the other dirs too.This PR introduces breaking changes. Users on
"moduleResolution": "node",will need to make changes likeI'd argue this is a good thing as it forces Solid (and users) to think about the API, buuuuut I'd get it if that means we need to wait for 0.4 before this PR gets any traction. Also, since I'll be moving nearly every file in
/start(to a nested/srcfolder), it may introduce conflicts with other PRs/branches. IMO this is a reason to get this done sooner rather than later, but choosing the right time may be important. Sorry if this ruins your timing, but I'm tired of getting ts errors in my node_modules 😭