Refactor #6
Merged
Refactor #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated function signatures and array formatting in `additional-javascript.php` for improved readability. - Changed `default_js_template` function declaration style for consistency. - Modified array syntax to use consistent spacing in `register_post_type_javascript` and `register_additional_javascript` functions. - Refactored jQuery usage to vanilla JavaScript in `additional-javascript-preview.js` for better performance and compatibility. - Enhanced comments to accurately describe functionality, particularly in the `custom_javascript` preview handler.
…aScript settings - Updated plugin version from 1.0.1 to 1.1.0 in additional-javascript.php. - Added a new comment for the version definition to clarify its purpose for cache-busting assets. - Changed capability from 'edit_css' to 'unfiltered_html' in class-custom-javascript-control.php to allow broader editing permissions. - Enhanced constructor documentation to specify exceptions and parameter types more clearly. - Improved code formatting for better readability and consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several updates to the
additional-javascriptplugin to improve functionality and maintainability. The most important changes include updating the plugin version, defining a version constant for cache-busting, modifying JavaScript and CSS enqueuing logic, updating capabilities for custom JavaScript settings, and refining exception handling.Version Update and Cache-Busting:
1.1.0and defined a constantADDITIONAL_JAVASCRIPT_VERSIONfor cache-busting assets. [1] [2]JavaScript and CSS Enqueuing:
Capability Update:
edit_csstounfiltered_html.Exception Handling:
Soderlind_Customize_Custom_JavaScript_Settingclass to use fully qualified class names and improved error messages.JavaScript Code Refinement: