fix(gui): use UI thread for adding logcat messages - #2811
Merged
Conversation
other minor/logging improvements for debugger and adb connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logcat messages were also added without proper UI synchronization.
I also made other improvements to adb and logcat handling like never closed sockets and never terminated executor.
Also the LogUtils.escape method was a bit restrictive what it filters out. I was very confused as this "log escaper" modified the ADB commands printed in the log. I relaxed that a bit.
As long term solution we may consider switching to
org.apache.commons.text.StringEscapeUtils.escapeJava(...).