Support Alphanumeric lock ids #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cks, since locks are returned as hex values)
Owner
|
Nice catch! My server only ever returns a number so I never saw this. I guess we don't know how servers will assign IDs, it might not even be hexadecimal, so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Git LFS test server
git lfs locks --verifyreturns something like this:O Content/MyAsset.uasset gkoreman ID:b0dd4d1797411e59b5e208eca08e3152faa2026dNote that the ID is not just numbers, so the \d in the regex fails to match. Changing the regex to match on alphanumeric fixed the issue for me.