-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(helm): add custom egress rules to realtime network policy #2481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(helm): add custom egress rules to realtime network policy #2481
Conversation
|
@Lutherwaves is attempting to deploy a commit to the Sim Team on Vercel. A member of the Team first needs to authorize it. |
Greptile SummaryThis PR fixes a missing configuration section in the realtime service network policy. The change adds the custom egress rules template block to the realtime network policy, bringing it into parity with the app network policy.
Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User as User/DevOps
participant Values as values.yaml
participant Helm as Helm Template Engine
participant RT as Realtime Network Policy
participant Ext as External Database
User->>Values: Configure networkPolicy.egress<br/>with custom rules
User->>Helm: Deploy/upgrade chart
Helm->>RT: Render template with<br/>custom egress rules
Note over RT: Before fix: Custom rules ignored<br/>After fix: Custom rules included
RT->>Ext: Allow egress to external DB<br/>(e.g., PostgreSQL :5432)
Ext-->>RT: Connection successful
|
The realtime service network policy was missing the custom egress rules section that allows configuration of additional egress rules via values.yaml. This caused the realtime pods to be unable to connect to external databases (e.g., PostgreSQL on port 5432) when using external database configurations. The app network policy already had this section, but the realtime network policy was missing it, creating an inconsistency and preventing the realtime service from accessing external databases configured via networkPolicy.egress values. This fix adds the same custom egress rules template section to the realtime network policy, matching the app network policy behavior and allowing users to configure database connectivity via values.yaml.
4b1ab75 to
31147b6
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…dioai#2481) The realtime service network policy was missing the custom egress rules section that allows configuration of additional egress rules via values.yaml. This caused the realtime pods to be unable to connect to external databases (e.g., PostgreSQL on port 5432) when using external database configurations. The app network policy already had this section, but the realtime network policy was missing it, creating an inconsistency and preventing the realtime service from accessing external databases configured via networkPolicy.egress values. This fix adds the same custom egress rules template section to the realtime network policy, matching the app network policy behavior and allowing users to configure database connectivity via values.yaml.
…dioai#2481) The realtime service network policy was missing the custom egress rules section that allows configuration of additional egress rules via values.yaml. This caused the realtime pods to be unable to connect to external databases (e.g., PostgreSQL on port 5432) when using external database configurations. The app network policy already had this section, but the realtime network policy was missing it, creating an inconsistency and preventing the realtime service from accessing external databases configured via networkPolicy.egress values. This fix adds the same custom egress rules template section to the realtime network policy, matching the app network policy behavior and allowing users to configure database connectivity via values.yaml.
Summary
The realtime service network policy was missing the custom egress rules section that allows configuration of additional egress rules via values.yaml. This caused the realtime pods to be unable to connect to external databases (e.g., PostgreSQL on port 5432) when using external database configurations.
The app network policy already had this section, but the realtime network policy was missing it, creating an inconsistency and preventing the realtime service from accessing external databases configured via networkPolicy.egress values.
This fix adds the same custom egress rules template section to the realtime network policy, matching the app network policy behavior and allowing users to configure database connectivity via values.yaml.
Fixes https://discord.com/channels/1344142560293290024/1441430398155493396/1441430398155493396
Type of Change
Testing
could not receive data from client: Connection reset by peerwas thrown by PSQLChecklist