-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat: place all styles in global vars #1923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryThis PR introduces a centralized color system by adding comprehensive CSS variables to Key Changes:
Concerns:
Confidence Score: 3/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant GC as globals.css
participant Comp as Components (77 files)
participant UI as UI Rendering
Dev->>GC: Add semantic color tokens<br/>(--bg, --surface-*, --text-*, etc.)
Dev->>GC: Add extended palette<br/>(--c-E5E5E5, --c-414141, etc.)
Dev->>GC: Add RGB variants for opacity
loop For each component
Dev->>Comp: Replace hardcoded hex colors
Comp-->>Comp: Update from bg-[#1E1E1E]
Comp-->>Comp: to bg-[var(--surface-1)]
Dev->>Comp: Update dark mode variants
Comp-->>Comp: Update from dark:bg-[#363636]
Comp-->>Comp: to dark:bg-[var(--surface-9)]
end
Dev->>Comp: Update .cursorrules examples
Comp->>GC: Reference CSS variables
GC->>UI: Apply consistent theming
Note over GC,UI: Centralized color management<br/>Single source of truth
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
74 files reviewed, no comments
7a92ef7 to
6e8ba70
Compare
Summary
Places all styles in global vars and fixes some styling elements.
Type of Change
Testing
Solo testing.
Checklist