-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(variables): fixed floating variables, added autcomplete off to prevent suggested values #1908
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryThis PR restores the floating variables modal feature with full collaborative support. The main changes include:
The variables modal now properly syncs changes across all collaborators in real-time through the socket-based collaborative workflow system. Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant PanelNew as Panel Component
participant VariablesStore as Variables Store
participant CollaborativeHook as useCollaborativeWorkflow
participant VariablesModal as Variables Modal
participant Socket as Socket/Backend
User->>PanelNew: Click Variables menu item
PanelNew->>VariablesStore: setIsOpen(true)
VariablesStore-->>VariablesModal: isOpen=true (render modal)
VariablesModal->>CollaborativeHook: Get collaborative functions
CollaborativeHook-->>VariablesModal: Return collaborative CRUD functions
User->>VariablesModal: Add new variable
VariablesModal->>CollaborativeHook: collaborativeAddVariable(data)
CollaborativeHook->>VariablesStore: addVariable(data, id)
CollaborativeHook->>Socket: Emit add variable operation
Socket-->>CollaborativeHook: Confirm operation
User->>VariablesModal: Update variable field
VariablesModal->>CollaborativeHook: collaborativeUpdateVariable(id, field, value)
CollaborativeHook->>VariablesStore: updateVariable(id, updates)
CollaborativeHook->>Socket: Emit update operation
Socket-->>CollaborativeHook: Confirm operation
User->>VariablesModal: Delete variable
VariablesModal->>CollaborativeHook: collaborativeDeleteVariable(id)
CollaborativeHook->>VariablesStore: deleteVariable(id)
CollaborativeHook->>Socket: Emit delete operation
Socket-->>CollaborativeHook: Confirm operation
Note over VariablesModal,Socket: All changes sync in real-time<br/>to other collaborators
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16 files reviewed, no comments
…event suggested values (#1908) * fixed variables * add autocomplete=off to prevent suggestions for subblock values
…event suggested values (#1908) * fixed variables * add autocomplete=off to prevent suggestions for subblock values
Summary
Type of Change
Testing
Tested manually
Checklist