-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(selectors-hydration): confluence, jira, teams #1907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile OverviewGreptile SummaryFixed critical hydration issues across Confluence, Jira, and Teams selectors by implementing proper state restoration on component mount. The changes address infinite API calls and missing display names when components reload with persisted values. Key improvements:
All changes follow consistent patterns for hydration handling and display name caching across selectors. Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant Component as Selector Component
participant Store as DisplayNames Store
participant API as Backend API
Note over Component: On Mount/Hydration
User->>Component: Component loads with existing value
Component->>Component: Check if value & credentials exist
Component->>Store: Check cached display name
alt No cached display name
Component->>API: Fetch access token
API-->>Component: Return access token
Component->>API: Fetch item details (page/issue/chat)
API-->>Component: Return item data
Component->>Store: Cache display name
Component->>Component: Update selectedItem state
else Display name cached
Component->>Component: Use cached name
end
Note over Component: On User Interaction
User->>Component: Opens dropdown
Component->>API: Fetch list of items
API-->>Component: Return items list
Component->>Store: Cache all item names
Component->>Component: Display items
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6 files reviewed, no comments
* fix(jira): issue and project selector * fix endpoints * remove # for selector * fix chat selector * add preview card for jira * fix inf calls for teams * fix inf teams calls * inf confluence calls * fix confluence selector * add small # back for slack channel selector * fix wealthbox selector
* fix(jira): issue and project selector * fix endpoints * remove # for selector * fix chat selector * add preview card for jira * fix inf calls for teams * fix inf teams calls * inf confluence calls * fix confluence selector * add small # back for slack channel selector * fix wealthbox selector
Summary
Fix confluence page selector, jira issues and project selectors, teams chat selectors.
Type of Change
Testing
Tested manually with @aadamgough
Checklist