Skip to content

Conversation

@emir-karabeg
Copy link
Collaborator

@emir-karabeg emir-karabeg commented Nov 11, 2025

Summary

  • workflow overhaul: updated action bar, triggers ordering, presence, cursor, renaming blocks

Type of Change

  • New feature

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Nov 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
docs Skipped Skipped Nov 12, 2025 0:28am

@waleedlatif1 waleedlatif1 changed the title Feat/w 2 feat(workflow): workflow overhaul Nov 11, 2025
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 11, 2025

Greptile Overview

Greptile Summary

This PR implements a comprehensive workflow overhaul focused on improving collaboration features and user experience.

Key Changes:

  • Replaced trigger list with CommandList component for empty workflows
  • Added global keyboard shortcut system via GlobalCommandsProvider
  • Implemented collaborative cursors with consistent user color assignment
  • Enhanced terminal with filtering, sorting, and run ID coloring
  • Refactored action bar with improved memoization
  • Added workspace collapse/expand functionality
  • Enhanced block operations (auto-focus on duplicate, clear selection on delete)
  • Cleaned up unused CSS animations and utilities

Custom Instruction Violations:

  • Modified globals.css (terminal height change) - custom rule requires avoiding this file and moving styles to component files instead

Previous Comments Addressed:
Two issues were previously flagged and are acknowledged in this review

Confidence Score: 4/5

  • This PR is safe to merge with minor considerations
  • The refactoring is well-structured with proper component separation and memoization. Previous comments identified two minor issues (event listener cleanup, missing dependency). One custom instruction violation (globals.css edit) exists but is minor. The removal of old components (TriggerList, CollaboratorCursorLayer, use-keyboard-shortcuts) is clean with no remaining references.
  • Pay attention to global-commands-provider.tsx (event listener cleanup) and terminal.tsx (dependency array) based on previous review comments. The globals.css change violates project guidelines.

Important Files Changed

File Analysis

Filename Score Overview
apps/sim/app/workspace/[workspaceId]/providers/global-commands-provider.tsx 4/5 added global keyboard shortcut system with platform-aware modifier key handling - previous comment noted event listener cleanup issue
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/cursors/cursors.tsx 5/5 new component for collaborative cursor display, replaces CollaboratorCursorLayer with simpler implementation
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/terminal/terminal.tsx 4/5 major terminal overhaul with new filtering, sorting, run ID coloring - previous comment about missing dependency
apps/sim/app/globals.css 4/5 removed unused CSS utilities and updated terminal height - violates custom instruction to avoid editing globals.css
apps/sim/hooks/use-collaborative-workflow.ts 5/5 enhanced block removal to clear editor selection and auto-focus duplicated blocks

Sequence Diagram

sequenceDiagram
    participant User
    participant GlobalCommandsProvider
    participant Sidebar
    participant Workflow
    participant Cursors
    participant Terminal
    participant Socket
    participant WorkflowStore

    User->>GlobalCommandsProvider: Press keyboard shortcut
    GlobalCommandsProvider->>GlobalCommandsProvider: Match shortcut to command
    GlobalCommandsProvider->>Sidebar: Execute command (e.g., open search)
    
    User->>Workflow: Move cursor on canvas
    Workflow->>Socket: Emit cursor position
    Socket->>Cursors: Broadcast to collaborators
    Cursors->>Cursors: Render cursors with user colors
    
    User->>Workflow: Click block
    Workflow->>WorkflowStore: Select block
    WorkflowStore->>Workflow: Update UI
    
    User->>Workflow: Execute workflow
    Workflow->>Terminal: Add console entries
    Terminal->>Terminal: Apply filters & sorting
    Terminal->>Terminal: Assign run ID colors
    Terminal->>User: Display filtered results
    
    User->>Workflow: Duplicate block
    Workflow->>WorkflowStore: Create duplicate
    WorkflowStore->>WorkflowStore: Auto-focus new block
    WorkflowStore->>Workflow: Update canvas
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. apps/sim/app/globals.css, line 4-14 (link)

    style: violates custom instruction to avoid editing globals.css unless absolutely necessary

    multiple style changes were made to this file, including terminal height change and removal of various CSS rules

    consider moving these to local component files instead

    Context Used: Context from dashboard - Avoid editing the globals.css file unless absolutely necessary. Move style changes to local componen... (source)

45 files reviewed, 3 comments

Edit Code Review Agent Settings | Greptile

Copy link
Collaborator

@waleedlatif1 waleedlatif1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

banger

@waleedlatif1
Copy link
Collaborator

@greptile

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

46 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@waleedlatif1 waleedlatif1 merged commit 7b48d6e into staging Nov 12, 2025
3 checks passed
@waleedlatif1 waleedlatif1 deleted the feat/w-2 branch November 12, 2025 00:30
@waleedlatif1 waleedlatif1 restored the feat/w-2 branch November 12, 2025 00:32
waleedlatif1 pushed a commit that referenced this pull request Nov 12, 2025
* feat: action-bar side-effects; refactor: removed unused styles from globals and tailwind config

* feat(terminal): filters/sorting; fix(workflow): zoom bug

* feat(sidebar): toggle; feat(terminal): show/hide timestamp

* feat(toolbar): triggers ordering

* feat: commands, cursors, room-presence, command-list, rename blocks, workspace controls, invite, search modal

* removed old imports

* ack PR comments

* fix tag dropdown

* feat: variables UI; fix: terminal keys

---------

Co-authored-by: waleed <waleed>
waleedlatif1 pushed a commit that referenced this pull request Nov 12, 2025
* feat: action-bar side-effects; refactor: removed unused styles from globals and tailwind config

* feat(terminal): filters/sorting; fix(workflow): zoom bug

* feat(sidebar): toggle; feat(terminal): show/hide timestamp

* feat(toolbar): triggers ordering

* feat: commands, cursors, room-presence, command-list, rename blocks, workspace controls, invite, search modal

* removed old imports

* ack PR comments

* fix tag dropdown

* feat: variables UI; fix: terminal keys

---------

Co-authored-by: waleed <waleed>
@waleedlatif1 waleedlatif1 mentioned this pull request Nov 12, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants