-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat(workflow): workflow overhaul #1906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
…lobals and tailwind config
Greptile OverviewGreptile SummaryThis PR implements a comprehensive workflow overhaul focused on improving collaboration features and user experience. Key Changes:
Custom Instruction Violations:
Previous Comments Addressed: Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant GlobalCommandsProvider
participant Sidebar
participant Workflow
participant Cursors
participant Terminal
participant Socket
participant WorkflowStore
User->>GlobalCommandsProvider: Press keyboard shortcut
GlobalCommandsProvider->>GlobalCommandsProvider: Match shortcut to command
GlobalCommandsProvider->>Sidebar: Execute command (e.g., open search)
User->>Workflow: Move cursor on canvas
Workflow->>Socket: Emit cursor position
Socket->>Cursors: Broadcast to collaborators
Cursors->>Cursors: Render cursors with user colors
User->>Workflow: Click block
Workflow->>WorkflowStore: Select block
WorkflowStore->>Workflow: Update UI
User->>Workflow: Execute workflow
Workflow->>Terminal: Add console entries
Terminal->>Terminal: Apply filters & sorting
Terminal->>Terminal: Assign run ID colors
Terminal->>User: Display filtered results
User->>Workflow: Duplicate block
Workflow->>WorkflowStore: Create duplicate
WorkflowStore->>WorkflowStore: Auto-focus new block
WorkflowStore->>Workflow: Update canvas
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
apps/sim/app/globals.css, line 4-14 (link)style: violates custom instruction to avoid editing
globals.cssunless absolutely necessarymultiple style changes were made to this file, including terminal height change and removal of various CSS rules
consider moving these to local component files instead
Context Used: Context from
dashboard- Avoid editing the globals.css file unless absolutely necessary. Move style changes to local componen... (source)
45 files reviewed, 3 comments
apps/sim/app/workspace/[workspaceId]/providers/global-commands-provider.tsx
Outdated
Show resolved
Hide resolved
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/terminal/terminal.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
banger
3f92d79 to
e6b2d13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
46 files reviewed, no comments
* feat: action-bar side-effects; refactor: removed unused styles from globals and tailwind config * feat(terminal): filters/sorting; fix(workflow): zoom bug * feat(sidebar): toggle; feat(terminal): show/hide timestamp * feat(toolbar): triggers ordering * feat: commands, cursors, room-presence, command-list, rename blocks, workspace controls, invite, search modal * removed old imports * ack PR comments * fix tag dropdown * feat: variables UI; fix: terminal keys --------- Co-authored-by: waleed <waleed>
* feat: action-bar side-effects; refactor: removed unused styles from globals and tailwind config * feat(terminal): filters/sorting; fix(workflow): zoom bug * feat(sidebar): toggle; feat(terminal): show/hide timestamp * feat(toolbar): triggers ordering * feat: commands, cursors, room-presence, command-list, rename blocks, workspace controls, invite, search modal * removed old imports * ack PR comments * fix tag dropdown * feat: variables UI; fix: terminal keys --------- Co-authored-by: waleed <waleed>
Summary
Type of Change
Testing
Tested manually
Checklist