-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(google-drive-picker): hydration issues with drive picker + dependsOn for trigger subblocks #1901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile OverviewGreptile SummaryThis PR fixes Google Drive Picker hydration issues and implements Key Changes:
Technical Implementation:
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant SubBlock
participant DependsOnGate
participant GoogleDrivePicker
participant DisplayNameStore
participant UseDisplayName
participant API
User->>SubBlock: Open workflow block
SubBlock->>DependsOnGate: Check dependencies (triggerCredentials)
DependsOnGate-->>SubBlock: Return disabled state
User->>SubBlock: Select credential
SubBlock->>DependsOnGate: Re-check dependencies
DependsOnGate-->>SubBlock: Dependencies satisfied, enable
User->>GoogleDrivePicker: Select file/folder
GoogleDrivePicker->>DisplayNameStore: Cache file name (setDisplayNames)
GoogleDrivePicker->>SubBlock: Return file info
User->>SubBlock: Reload workflow
SubBlock->>UseDisplayName: Request display name
UseDisplayName->>DisplayNameStore: Check cache
alt Cache hit
DisplayNameStore-->>UseDisplayName: Return cached name
else Cache miss
UseDisplayName->>API: Fetch file by ID
API-->>UseDisplayName: Return file data
UseDisplayName->>DisplayNameStore: Cache name
DisplayNameStore-->>UseDisplayName: Return name
end
UseDisplayName-->>SubBlock: Display hydrated name
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10 files reviewed, no comments
waleedlatif1
pushed a commit
that referenced
this pull request
Nov 12, 2025
…sOn for trigger subblocks (#1901) * fix(google-drive-picker): hydration issues with drive picker * respect depends on gating * add depends on for outlook polling * remove useless file * fix lint
waleedlatif1
pushed a commit
that referenced
this pull request
Nov 12, 2025
…sOn for trigger subblocks (#1901) * fix(google-drive-picker): hydration issues with drive picker * respect depends on gating * add depends on for outlook polling * remove useless file * fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist