Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • migrate to blacksmith runners, other runners alr use blacksmith

Type of Change

  • Other: CI

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Nov 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
docs Building Building Preview Comment Nov 11, 2025 2:53am

@waleedlatif1 waleedlatif1 merged commit 4b37f92 into staging Nov 11, 2025
3 of 4 checks passed
@waleedlatif1 waleedlatif1 deleted the improvement/ci branch November 11, 2025 02:53
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 11, 2025

Greptile Overview

Greptile Summary

Migrated ARM64 build jobs from linux-arm64-8-core to blacksmith-8vcpu-ubuntu-2404-arm runners across CI and image build workflows, aligning with the existing blacksmith runner usage in other workflows.

  • Updated .github/workflows/ci.yml ARM64 build job runner (.github/workflows/ci.yml:115)
  • Updated .github/workflows/images.yml ARM64 build job runner (.github/workflows/images.yml:103)
  • All other jobs already use blacksmith runners (AMD64 builds, manifests, etc.)
  • No functional changes to the CI logic or build process

Confidence Score: 5/5

  • Safe to merge - straightforward runner migration with no functional changes
  • This is a simple infrastructure change that only modifies the runner specification for ARM64 builds. All other workflows already use blacksmith runners successfully, and the change maintains equivalent compute resources (8 vCPU). No code logic, dependencies, or build configuration changes.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/ci.yml 5/5 Migrated ARM64 build job from linux-arm64-8-core to blacksmith-8vcpu-ubuntu-2404-arm runner
.github/workflows/images.yml 5/5 Migrated ARM64 build job from linux-arm64-8-core to blacksmith-8vcpu-ubuntu-2404-arm runner

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub
    participant TestBuild as Test-Build Job
    participant AMD64 as Build-AMD64 Job
    participant ARM64 as Build-ARM64 Job
    participant Manifest as Create-Manifests Job
    participant ECR as Amazon ECR
    participant GHCR as GitHub Container Registry

    Dev->>GH: Push to main/staging
    GH->>TestBuild: Trigger CI workflow
    TestBuild->>TestBuild: Run tests and build
    
    par Parallel builds after tests pass
        TestBuild-->>AMD64: Tests passed
        AMD64->>AMD64: Run on blacksmith-4vcpu-ubuntu-2404
        AMD64->>ECR: Push AMD64 images (all branches)
        AMD64->>GHCR: Push AMD64 images (main only)
        
        TestBuild-->>ARM64: Tests passed (main only)
        ARM64->>ARM64: Run on blacksmith-8vcpu-ubuntu-2404-arm
        ARM64->>GHCR: Push ARM64 images (main only)
    end
    
    par Wait for both builds (main only)
        AMD64-->>Manifest: AMD64 images ready
        ARM64-->>Manifest: ARM64 images ready
    end
    
    Manifest->>Manifest: Run on blacksmith-4vcpu-ubuntu-2404
    Manifest->>GHCR: Create multi-arch manifests
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants