-
Notifications
You must be signed in to change notification settings - Fork 3.1k
feat(permissions): extend hook to detect missing scopes to return those scopes for upgrade, update credential selector subblock #1869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
…se scopes for upgrade, update credential selector subblock
6e128a2 to
348d224
Compare
Greptile OverviewGreptile SummaryExtended OAuth scope management to detect and prompt users to upgrade credentials when additional permissions are required, with UI improvements to clearly communicate missing scopes. Key Changes
Implementation QualityThe implementation is well-structured with proper separation of concerns. The new utility functions are reusable and the UI feedback is clear and user-friendly. Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant CredentialSelector
participant Hook as getMissingRequiredScopes
participant CredentialsAPI
participant Modal as OAuthRequiredModal
participant OAuthProvider
User->>CredentialSelector: Select credential
CredentialSelector->>Hook: Check missing scopes
Hook-->>CredentialSelector: Return missing scopes list
alt Missing scopes found
CredentialSelector->>CredentialSelector: Show permissions banner
User->>CredentialSelector: Click Update button
CredentialSelector->>Modal: Open modal
Modal->>Modal: Display scope list
User->>Modal: Click Connect
Modal->>OAuthProvider: Initiate flow
OAuthProvider-->>CredentialsAPI: Send authorization
CredentialsAPI->>CredentialsAPI: Parse and evaluate scopes
CredentialsAPI-->>CredentialSelector: Updated credential data
CredentialSelector->>Hook: Recheck scopes
Hook-->>CredentialSelector: No missing scopes
CredentialSelector->>CredentialSelector: Hide banner
end
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8 files reviewed, no comments
…se scopes for upgrade, update credential selector subblock (#1869)
…se scopes for upgrade, update credential selector subblock (#1869)
Summary
Type of Change
Testing
Tested manually
Checklist