-
Notifications
You must be signed in to change notification settings - Fork 0
Fix StableValue supplier object method delegation #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
31ca0c5
Issue #76 StableValue supplier missing object method delegation
simbo1905 449fe2b
Update copyright notice in EscapedKeyBugTest.java
simbo1905 d319174
Issue #76 Update CI pipeline test expectations
simbo1905 45c527d
Merge branch 'investigate-issue-74' of github.com:simbo1905/java.util…
simbo1905 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
102 changes: 102 additions & 0 deletions
102
json-java21/src/test/java/jdk/sandbox/java/util/json/EscapedKeyBugTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| /* | ||
| * Copyright (c) 2025, Simon Massey. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. Oracle designates this | ||
| * particular file as subject to the "Classpath" exception as provided | ||
| * by Oracle in the LICENSE file that accompanied this code. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
| /* | ||
| * @test | ||
| * @enablePreview | ||
| * @summary Test escaped characters in JSON object keys | ||
| * @run junit EscapedKeyBugTest | ||
| */ | ||
|
|
||
| package jdk.sandbox.java.util.json; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
| import static org.junit.jupiter.api.Assertions.*; | ||
| import java.util.logging.Logger; | ||
|
|
||
| public class EscapedKeyBugTest { | ||
| private static final Logger LOGGER = Logger.getLogger(EscapedKeyBugTest.class.getName()); | ||
|
|
||
| @Test | ||
| public void testEscapedCharactersInKeys() { | ||
| LOGGER.info("Executing testEscapedCharactersInKeys"); | ||
| // Should parse successfully with escaped characters in keys | ||
| String json = """ | ||
| {"foo\\nbar":1,"foo\\tbar":2} | ||
| """; | ||
|
|
||
| JsonValue result = Json.parse(json); | ||
| JsonObject obj = (JsonObject) result; | ||
|
|
||
| // Verify both keys are parsed correctly | ||
| assertEquals(1L, ((JsonNumber) obj.members().get("foo\nbar")).toNumber()); | ||
| assertEquals(2L, ((JsonNumber) obj.members().get("foo\tbar")).toNumber()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testEscapedQuoteInKey() { | ||
| LOGGER.info("Executing testEscapedQuoteInKey"); | ||
| // Test escaped quotes in keys | ||
| String json = """ | ||
| {"foo\\"bar":1} | ||
| """; | ||
|
|
||
| JsonValue result = Json.parse(json); | ||
| JsonObject obj = (JsonObject) result; | ||
|
|
||
| // Verify key with escaped quote is parsed correctly | ||
| assertEquals(1L, ((JsonNumber) obj.members().get("foo\"bar")).toNumber()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testEscapedBackslashInKey() { | ||
| LOGGER.info("Executing testEscapedBackslashInKey"); | ||
| // Test escaped backslashes in keys | ||
| String json = """ | ||
| {"foo\\\\bar":1} | ||
| """; | ||
|
|
||
| JsonValue result = Json.parse(json); | ||
| JsonObject obj = (JsonObject) result; | ||
|
|
||
| // Verify key with escaped backslash is parsed correctly | ||
| assertEquals(1L, ((JsonNumber) obj.members().get("foo\\bar")).toNumber()); | ||
| } | ||
|
|
||
| @Test | ||
| public void testMultipleEscapedCharactersInKey() { | ||
| LOGGER.info("Executing testMultipleEscapedCharactersInKey"); | ||
| // Test multiple escaped characters in one key | ||
| String json = """ | ||
| {"foo\\n\\t\\"bar":1} | ||
| """; | ||
|
|
||
| JsonValue result = Json.parse(json); | ||
| JsonObject obj = (JsonObject) result; | ||
|
|
||
| // Verify key with multiple escaped characters is parsed correctly | ||
| assertEquals(1L, ((JsonNumber) obj.members().get("foo\n\t\"bar")).toNumber()); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Avoid breaking Supplier equality contract
The new
equalsandhashCodeimplementations delegate straight to the cached value without checking the argument type. As a result a supplier now reportstruewhen compared with its underlying value (supplier.equals("foo")) while the reverse comparison ("foo".equals(supplier)) remainsfalse. This violates the symmetry requirement ofObject.equalsand can corrupt hash-based collections when suppliers are used as keys. Consider keeping identity semantics or only comparing other suppliers by their cached value.Useful? React with 👍 / 👎.