Fix positioning bug for disabled gpu optimizations #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 14, 2016 09:25
Issue observed when position of tether element is set with the css properties top, left, bottom or right. Before writing the css to the element's style their values are parsed to floats, presumably related to the check against the current css value. This incorrectly converts '5px' > 5, which is an illegal css value and is ignored by the browser. Conversion to float would seem to be incorrect and is removed.
Contributor
|
Oof. Confirmed! Thanks for the fix. |
Contributor
|
@johgusta Out of curiosity, does this mean that you've found a situation where setting optimizations: {
gpu: false
}is necessary? |
Author
|
We're using Drop.js to dynamically display popups and we sometimes experienced issues with blurred text. It would seem to be caused by how webkit handles subpixel antialiasing when rendering on the GPU, http://keithclark.co.uk/articles/gpu-text-rendering-in-webkit/. |
Contributor
|
Very interesting. That might be worth mentioning in the documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue observed when position of tether element is
set with the css properties top, left, bottom or
right.
Before writing the css to the element's
style their values are parsed to floats, presumably
related to the check against the current css value.
This incorrectly converts '5px' > 5, which is an
illegal css value and is ignored by the browser.
Conversion to float would seem to be incorrect and
is removed.