make it safe to import tether in Node code #123
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This seems like a duplicate of #117. I'll be taking a look at that PR soon to see if there are better ways to handle this issue, but a fix should be right around the corner 👍 |
Author
|
Bah, missed that! Good to know the fix is coming. |
Contributor
|
Yup! Just came back from hiatus so slowly getting back to reviewing these outstanding issues. Feel free to follow that PR to track when it gets merged, but like I mentioned, I'm aiming for very, very, very soon 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am developing an isomorphic application that uses Tether. Obviously it is not expected to do anything useful on the server side, but it gets loaded all the same with the rest of the client code.
Right now there are two places in the code that, even without actually tethering any elements, still access
documentandwindow. Naturally, Node isn't too happy about that. This fix makes Tether load without crashing.PS: I nuked
dist/and rerannpm run buildas per the instructions inCONTRIBUTING.md, but this created spurious changes. I'm including them, but the only real changes are insrc/js/tether.js.