Conversation
jwilsson
left a comment
There was a problem hiding this comment.
Looks really nice, just some thoughts.
gulpfile.js
Outdated
| @@ -0,0 +1,32 @@ | |||
| 'use strict'; | |||
|
|
|||
| const del = require('del'); | |||
There was a problem hiding this comment.
Looks like this is unused, right?
There was a problem hiding this comment.
🦑 (closest thing to squashed i could find)
|
|
||
| replaceWith (...nodes) { | ||
| replaceWith () { | ||
| let nodes = Array.prototype.slice.call(arguments); |
There was a problem hiding this comment.
Array.from should work here, right?
http://node.green/#Array-static-methods
There was a problem hiding this comment.
6 of one, half dozen of another :)
| { | ||
| "name": "postcss-values-parser", | ||
| "version": "0.1.8", | ||
| "version": "1.0.0", |
package.json
Outdated
| "babel-preset-stage-0": "^6.3.13", | ||
| "chai": "3.5.0", | ||
| "chai-shallow-deep-equal": "^1.4.0", | ||
| "del": "^2.2.0", |
There was a problem hiding this comment.
Just a friendly reminder to delete it here as well.
test/word.js
Outdated
| ] | ||
| }, | ||
| { | ||
| it: 'should parse custom variables', |
There was a problem hiding this comment.
Copy/paste error from above?
|
Something to think about: I've been thinking of publishing a |
| value = word.slice(ind, index), | ||
| node; | ||
|
|
||
| if (~hasAt.indexOf(ind)) { |
There was a problem hiding this comment.
Could hasAt.includes be used instead?
http://node.green/#String-prototype-methods
There was a problem hiding this comment.
is there a really good reason for includes over indexOf?
There was a problem hiding this comment.
Bit easier to read IMO, but just a thought.
|
re: the eslint config, yeah I'm planning on a shared config for all my projects as well. it's on my todo list. also need to get one going for the company I work for. |
Fixed a few bugs. Got rid of Babel.