support extensionKind ui and workspace - #50
Merged
Conversation
Contributor
Author
|
👋🏻 @shardulm94 |
Owner
|
@leighmcculloch On further testing, I realized that the "Delete Trailing Spaces - Modified Lines Only" feature, which requires access to the persisted file on disk, does not work correctly in UI mode. So I will be marking the extension as workspace only for now. |
Contributor
Author
|
Ahh. Got it! |
shardulm94
added a commit
that referenced
this pull request
Jun 20, 2026
Added @leighmcculloch (PR #50, extension kinds) and @dnicolson (PR #78, isNullOrUndefined deprecation fix) to the Contributions list — the two merged external contributions that were not yet credited. (Dependabot's automated dependency bumps are excluded, matching the existing human-contributor convention.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
shardulm94
added a commit
that referenced
this pull request
Jun 20, 2026
Added @leighmcculloch (PR #50, extension kinds) and @dnicolson (PR #78, isNullOrUndefined deprecation fix) to the Contributions list — the two merged external contributions that were not yet credited. (Dependabot's automated dependency bumps are excluded, matching the existing human-contributor convention.) Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Indicate to VSCode that the extension can run in
uimode or inworkspacemode.Why
When using VSCode with remote containers support VSCode can run extensions locally where the UI is being displayed or remotely where the files live. Many extension can run in either location, although some extension can only run on the ui side and some can only run on the workspace side.
When an extension doesn't indicate where it can be run it always runs at the workspace side.
The trailing spaces extension can run either on the UI or on the workspace and I think it should really be up to the user to choose, by default running in the ui since it works perfectly fine in the UI. The advantage of changing this and indicating it can run in both places is that when using remote dev containers the developer doesn't have to manually install the extension in the container to use it.