Enable the 'unsafe_op_in_unsafe_fn' lint#1328
Merged
stevenengler merged 1 commit intoshadow:devfrom May 13, 2021
Merged
Conversation
Contributor
Author
|
Oops, forgot that we're using an older nightly version for the coverage. I'll see if we can update that. |
sporksmith
approved these changes
May 7, 2021
Contributor
sporksmith
left a comment
There was a problem hiding this comment.
Yay! Yeah it always bothered me that it wouldn't even let you use unsafe blocks in an unsafe function (or at least it would warn?), much less require it.
LGTM pending getting coverage working again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
unsafe_op_in_unsafe_fnRust lint has been stabilized and I think we should use it. The lint is currently off by default, but they plan to make it a warning and possibly an error in the future.Edit: Blocked on #1330.