Skip to content

Fix port number overflow #2826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merrymercy merged 4 commits into from
Jan 10, 2025
Merged

Fix port number overflow #2826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1036dd
Fix port overflow
gty111 Jan 10, 2025
584b1b9
format
gty111 Jan 10, 2025
51d2dd6
Apply suggestions from code review
merrymercy Jan 10, 2025
eeacdd2
Update python/sglang/srt/server_args.py
merrymercy Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion python/sglang/srt/server_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,7 +928,10 @@ def init_new(server_args) -> "PortArgs":
while True:
if is_port_available(port):
break
port += 42
if port < 60000:
port += 42
else:
port -= 43

return PortArgs(
tokenizer_ipc_name=tempfile.NamedTemporaryFile(delete=False).name,
Expand Down
2 changes: 2 additions & 0 deletions python/sglang/srt/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,6 +335,8 @@ def is_port_available(port):
return True
except socket.error:
return False
except OverflowError:
return False


def decode_video_base64(video_base64):
Expand Down
Loading