Fix missing procps on FrankenPHP Variation #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Fixes missing system dependencies in FrankenPHP Docker variations that were causing Laravel healthcheck failures due to missing pgrep command.
- Added
gettextpackages for both Alpine and Debian variants - Added
procps(containspgrep) andzippackages for Debian variant
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Member
|
Thanks for pointing this out! Not sure if this whole PR was AI submitted, but we don't need I removed those and will get this published in Beta2 👍 |
Contributor
Author
|
My bad i had copy paste my lines |
arnaud-ritti
referenced
this pull request
in YieldStudio/docker-php
Oct 28, 2025
* 280-create-a-frankenphp-variation: (132 commits) Remove deprecated Dockerfiles and configuration files for FPM, Unit, and Nginx variations; update FrankenPHP configurations and entrypoints for improved structure and clarity. Updated installation documentation to enhance clarity on PHP variations, including detailed descriptions for CLI, FPM, FPM-Apache, FPM-NGINX, and FrankenPHP. Marked NGINX Unit as deprecated and provided migration guidance. Improved overall structure for better user understanding. Refactored Caddyfile structure for better SSL experience Added FrankenPHP version during build (Fixes #577) Set proper XDG_* paths Added "acme" certificate mode for FrankenPHP Remove version declaration from Docker Compose example in PHP settings documentation Moved folders Renamed folders Renamed getting started folder Add Docker introduction and benefits to installation documentation Update documentation to replace 'NGINX Unit variation' with 'FrankenPHP variation' in the getting started guide. Add instructions for computing the Alpine key hash and building with the new hash in contributing documentation Fix missing procps on FrankenPHP Variation (#571) Add healthcheck configuration to Dockerfile and Caddyfile for frankenphp variation Add Caddy logging configuration to Dockerfile for frankenphp variation Enhance Laravel automation scripts with new migration options and improved error handling. Added support for multiple databases, migration modes, and seeding. Updated documentation to reflect these changes and added a new script for testing database connections. Fixed notice of `/package/admin/s6-overlay/libexec/preinit: info: /run belongs to uid X instead of Y` for FPM-NGINX on Alpine Refactor Laravel migration script to build migration flags dynamically and improve error handling for isolated migrations. Added debug logs for new environment variables related to migrations. Update Laravel documentation links to reflect version 12.x changes for health checks, task scheduler, and Reverb setup instructions. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For FrankenPHP variations Laravel healthcheck didn't work decause pgrep was missing.