Skip to content

Added Javadocs. #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thinkingserious merged 1 commit into from
Oct 10, 2017
Merged

Added Javadocs. #247

thinkingserious merged 1 commit into from
Oct 10, 2017

Conversation

@andy-trimble
Copy link
Contributor

@andy-trimble andy-trimble commented Oct 10, 2017

This addresses issue #130

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Oct 10, 2017
@mbernier mbernier added difficulty: medium fix is medium in difficulty hacktoberfest labels Oct 10, 2017
mbernier
mbernier approved these changes Oct 10, 2017
View reviewed changes
Copy link
Contributor

@mbernier mbernier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@thinkingserious thinkingserious merged commit 68d82d9 into master Oct 10, 2017
@thinkingserious
Copy link
Contributor

thinkingserious commented Oct 10, 2017

Hello @andy-trimble,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

thinkingserious added a commit that referenced this pull request Oct 10, 2017
@thinkingserious
Version Bump v4.1.1: PR #247 Added Javadocs.
2afa519
@childish-sambino childish-sambino deleted the javadoc branch January 16, 2020 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mbernier mbernier mbernier approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andy-trimble @thinkingserious @mbernier