Skip to content

Make fine tuning http client possible #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ikatkov wants to merge 1 commit into from
Closed

Make fine tuning http client possible #119

ikatkov wants to merge 1 commit into from

Conversation

@ikatkov
Copy link

@ikatkov ikatkov commented Jul 13, 2016

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap status: help wanted requesting help from the community status: cla needed labels Jul 13, 2016
@dmaicher dmaicher mentioned this pull request Oct 10, 2016
Merged
@dmaicher
Copy link
Contributor

dmaicher commented Oct 10, 2016

I don't think the SendGrid class should have knowledge about the http client which imho is an internal detail of the Client abstraction 😉

I would propose this #158

@ikatkov
Copy link
Author

ikatkov commented Oct 11, 2016

@dmaicher I +1 #158
Will kill this one once yours is merged. They will not merge until you do CLA

@ikatkov
Copy link
Author

ikatkov commented Oct 11, 2016

see #158

@ikatkov ikatkov closed this Oct 11, 2016
@ikatkov ikatkov deleted the timeouts branch October 11, 2016 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status: help wanted requesting help from the community type: community enhancement feature request not on Twilio's roadmap

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ikatkov @dmaicher @thinkingserious @igorkatkov