Repository navigation
[ESSREDUCE] Apply TransformationOverrides to chopper positions - #890
Open
SimonHeybrock wants to merge 1 commit into
Open
SimonHeybrock wants to merge 1 commit into
SimonHeybrock wants to merge 1 commit into
Conversation
parse_raw_choppers computed positions from the depends_on chain stored in each NXdisk_chopper group, so overrides never reached choppers. It now takes NeXusMultiTransformationChain[NXdisk_chopper, RunType], which has the overrides applied, and uses those chains in place of the stored ones. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Merged
4 of 6 tasks
SimonHeybrock
added a commit
to scipp/esslivedata
that referenced
this pull request
Nov 19, 2026
The chains are pinned because essreduce does not apply TransformationOverrides to choppers (scipp/ess#890) and both positioners share one PV, not because the generator trims the NXlog: trimming to a placeholder is how live transforms are meant to work. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent #858 added
TransformationOverrides(see there for more context). It turned out that this was incomplete:TransformationOverridesdid not reach choppers:parse_raw_chopperscomputed positions from thedepends_onchain stored in eachNXdisk_choppergroup. It now readsNeXusMultiTransformationChain[NXdisk_chopper, RunType], which has the overrides applied, so a chopper on a motorised stage can take its position from a streamed value like any other component.Motivation: in esslivedata the wavelength lookup table is built from a geometry artifact in which motor-driven transforms are length-0 placeholders, filled from Kafka through
TransformationOverrides. ODIN's WFM choppers sit on a linear stage (see #856), so their chains have such a placeholder. Without this change esslivedata has to cut the chain in the artifact and pin the choppers at motor position 0.With no overrides set, positions are unchanged.
🤖 Generated with Claude Code