Skip to content

Conversation

@Czaki
Copy link
Contributor

@Czaki Czaki commented Feb 28, 2023

This PR is the first to solve a problem mentioned in #38.

It is possible that call

__getattr__, __lazy_dir__, _ = lazy.attach_stub(__name__, __file__)

Will provide the file name with .pyc extension so the lazy loader tries to open .pyci file, which does not exist.

@Czaki
Copy link
Contributor Author

Czaki commented Mar 2, 2023

@stefanv What should I do to have this reviewed/merged?

@stefanv
Copy link
Member

stefanv commented Mar 2, 2023

This looks fine; happy to merge if the tests pass.

@Czaki
Copy link
Contributor Author

Czaki commented Mar 2, 2023

Only linter fails on clone from gitlab. Should I fix it?

@stefanv stefanv merged commit e1e48fa into scientific-python:main Mar 2, 2023
@stefanv
Copy link
Member

stefanv commented Mar 2, 2023

No worries, I got it. Thank you!

@Czaki
Copy link
Contributor Author

Czaki commented Mar 13, 2023

@stefanv is there a plan to release this?
I could add a second PR with documentation how to handle with pyinstaller packages that are using this package if it is required/nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants