Break analysis into snippets #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Member
Author
|
I can't get devstats to build the website after either #15 or #16. I can build the website with this and it breaks up the scripts so that we can work on them today. If you want to refactor this later that should still be possible. I am just trying to get something that people can work on at the summit before it is over. I don't know how to move forward with main as it is now. |
Member
Author
|
This is a temporary fix and we will eventually replace it with the direction in #15 and #16. See: I then reset main to the previous commit, so I can merge this. I will integrate building the devstats website into the CI system here so it is easier to ensure this tool can be used to build the website moving forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #15 and #16, but it works with the current version of devstats.scientific-python.org. I am thinking of resetting main to commit d38e363 and merging this. I can then add building the devstats.scientific-python.org as a CI test for the devstats tool so that we can make sure we don't break the website while developing this tool.
We should revisit the approach in #15 and #16 later.