Skip to content

Adds Wall and Werror to ci workflows - #78

Open
rawildman wants to merge 3 commits into
developfrom
77-add-wall-and-werror-to-ci-workflows
Open

rawildman wants to merge 3 commits into
developfrom
77-add-wall-and-werror-to-ci-workflows

Conversation

@rawildman

@rawildman rawildman commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

This adds warnings-as-errors for the CI builds and also Wall. This also fixes the couple of warnings that surfaced. Wall is a fairly minimal set, so we'll incrementally add more warnings from here.

Closes: #77

@rawildman rawildman linked an issue Nov 20, 2026 that may be closed by this pull request
return values_.at(key);
}

virtual int get_level() const = 0;

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The warning here was the existence of this pure virtual function in a class that has no virtual dtor. I thought it'd make sense to get rid of the virtual function rather than add a virtual dtor, since it was straightforward to work around.

@rvuchkov007 rvuchkov007 Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rawildman Question why are we putting final here?

@rvuchkov007 rvuchkov007 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good, I am just confused on one thing

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Wall and Werror to CI workflows

2 participants