-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master] fix(nacl): Update generate pk using the sk
procedure
#66901
Conversation
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar. |
generate pk using the sk
proceduregenerate pk using the sk
procedure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, could we get a test for this?
assert pk file content
Definitely A test was already written for this case, which did not have the necessary coverage and only checked the console output. I completed this function and file content check was added to it. |
This overlaps with my PR #66773 which fixes the same issue (and a related second one). |
I thought the nacl stuff was slated to be moved to a community driven extension. Looks we missed |
Merged #66773, closing this as duplicate. |
What does this PR do?
Fix the
generate pk using the sk
procedure ingenkey
function of thesalt.utils.nacl
file.What issues does this PR fix or reference?
Fixes #66900
Previous Behavior
Generate the wrong
pk
value because it's the same assk
.New Behavior
Generate the correct
pk
value.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes