Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] fix(nacl): Update generate pk using the sk procedure #66901

Closed
wants to merge 3 commits into from

Conversation

hatamiarash7
Copy link

@hatamiarash7 hatamiarash7 commented Sep 18, 2024

What does this PR do?

Fix the generate pk using the sk procedure in genkey function of the salt.utils.nacl file.

What issues does this PR fix or reference?

Fixes #66900

Previous Behavior

Generate the wrong pk value because it's the same as sk.

New Behavior

Generate the correct pk value.

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes

@hatamiarash7 hatamiarash7 requested a review from a team as a code owner September 18, 2024 09:12
Copy link

welcome bot commented Sep 18, 2024

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@salt-project-bot-prod-environment salt-project-bot-prod-environment bot changed the title fix(nacl): Update generate pk using the sk procedure [master] fix(nacl): Update generate pk using the sk procedure Sep 18, 2024
Copy link
Contributor

@twangboy twangboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, could we get a test for this?

@hatamiarash7
Copy link
Author

Hey, could we get a test for this?

Definitely

A test was already written for this case, which did not have the necessary coverage and only checked the console output. I completed this function and file content check was added to it.

@hurzhurz
Copy link
Contributor

This overlaps with my PR #66773 which fixes the same issue (and a related second one).

@dwoz
Copy link
Contributor

dwoz commented Sep 19, 2024

I thought the nacl stuff was slated to be moved to a community driven extension. Looks we missed salt/utils/nacl.py and salt/renderers/nacl.py.

@dwoz
Copy link
Contributor

dwoz commented Sep 19, 2024

Merged #66773, closing this as duplicate.

@dwoz dwoz closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] NACL - Problem with generate pk using the sk procedure
4 participants