Update outdated base price definitions #1436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
IKarbowiak
reviewed
Jan 13, 2025
Comment on lines
57
to
+58
|
|
||
| The order discounts can be combined with catalogue discounts, and in such cases, the discount is calculated based on the discounted price. | ||
| The order discounts can be combined with [`line-level discounts`](developer/discounts/overview.mdx#level), and in such cases, the discount is calculated based on the discounted price. |
There was a problem hiding this comment.
Are you sure that order discount is calculated after applying specific product voucher?
There was a problem hiding this comment.
You are right. The order promotion doesn't combine with vouchers. I close the ticket then
|
The order promotion doesn't combine with vouchers, do I close the ticket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR updates base price definitions in Promotion section and few mistakes in Price Calculation section