Add basic support for xiaomi.aircondition.mc1, mc2, mc4, mc5 #825
+816
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e43cfd6 to
031726c
Compare
This commit introduced basic support and tests for MIoT device Xiaomi Mi Smart Air Conditioner A including xiaomi.aircondition.mc1, mc2, mc4 and mc5 since they are nearly the same in miot-spec. Tested on my xiaomi.aircondition.mc4. All properties and function work except property `electricity' keeps zero. Device miot-spec: http://miot-spec.org/miot-spec-v2/instance?type=urn:miot-spec-v2:device:air-conditioner:0000A004:xiaomi-mc4:1 Device Mi Home plugin: https://cdn.cnbj1.fds.api.mi-img.com/rn-plugins/2020-08-25/signed_10043_1000595_66_ANDROID_bundle_d8d30e612b4b0722e4a74744614f3c53.zip
031726c to
6801702
Compare
rytilahti
requested changes
Oct 3, 2020
Owner
rytilahti
left a comment
There was a problem hiding this comment.
Thanks for the PR, it's great to see more miot devices supported 🎉 A couple of small changes are needed, but otherwise this looks to be good to go.
rytilahti
reviewed
Oct 4, 2020
syssi
approved these changes
Nov 5, 2020
Collaborator
syssi
left a comment
There was a problem hiding this comment.
LGTM! Let's merge this new device!
rytilahti
approved these changes
Nov 5, 2020
Owner
rytilahti
left a comment
There was a problem hiding this comment.
Okay, let's get it merged! 🎉
xvlady
pushed a commit
to xvlady/python-miio
that referenced
this pull request
May 9, 2021
…ti#825) * Add basic support for xiaomi.aircondition.mc1, mc2, mc4, mc5 This commit introduced basic support and tests for MIoT device Xiaomi Mi Smart Air Conditioner A including xiaomi.aircondition.mc1, mc2, mc4 and mc5 since they are nearly the same in miot-spec. Tested on my xiaomi.aircondition.mc4. All properties and function work except property `electricity' keeps zero. Device miot-spec: http://miot-spec.org/miot-spec-v2/instance?type=urn:miot-spec-v2:device:air-conditioner:0000A004:xiaomi-mc4:1 Device Mi Home plugin: https://cdn.cnbj1.fds.api.mi-img.com/rn-plugins/2020-08-25/signed_10043_1000595_66_ANDROID_bundle_d8d30e612b4b0722e4a74744614f3c53.zip * Drop `incasesensitive' argument since it is the default behaviour of `EnumType' * Add example response, change fan level to fan speed * Add detailed parser and description for 'timer' and 'clean' * Rename running_duration to total_running_duration * Rename fan_percent to fan_speed_percent * Rename the mapped miot property too * Update docstrings * Fix tests Co-authored-by: Sebastian Muszynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduced basic support and tests for MIoT device
Xiaomi Mi Smart Air Conditioner A including xiaomi.aircondition.mc1,
mc2, mc4 and mc5 since they are nearly the same in miot-spec.
Tested on my xiaomi.aircondition.mc4. All properties and function work
except property `electricity' keeps zero.
Device miot-spec:
http://miot-spec.org/miot-spec-v2/instance?type=urn:miot-spec-v2:device:air-conditioner:0000A004:xiaomi-mc4:1
Device Mi Home plugin:
https://cdn.cnbj1.fds.api.mi-img.com/rn-plugins/2020-08-25/signed_10043_1000595_66_ANDROID_bundle_d8d30e612b4b0722e4a74744614f3c53.zip