Use normalized property names for genericmiotstatus #1723
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the way genericmiotstatus properties are accessed to use normalized names (e.g., light:on = light_on, brush-cleaner:brush-life-level = brush_cleaner_brush_life_level) to make them valid python identifiers, and thus directly accessible using the regular attribute access.
__dir__()is now also implemented for GenericMiotStatus to enable autocompleting these names for easier repling.Example using
mijia.vacuum.v2: