Add Roborock S7 MaxV Ultra station sensors #1608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1608 +/- ##
==========================================
- Coverage 80.19% 80.19% -0.01%
==========================================
Files 159 159
Lines 15711 15729 +18
Branches 3492 3500 +8
==========================================
+ Hits 12600 12614 +14
- Misses 2858 2860 +2
- Partials 253 255 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Looks good to me |
rytilahti
requested changes
Dec 5, 2022
Owner
rytilahti
left a comment
There was a problem hiding this comment.
LGTM, but could you check the wording of the properties & add simple tests for these two?
32abd20 to
ef8416d
Compare
Contributor
Author
|
@starkillerOG @rytilahti thanks for your review. I've implemented the suggestions and added two tests for both properties. |
rytilahti
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two sensors of the auto-emptying and washing station of the Roborock S7 MaxV.