fix lumi.plug.mmeu01 ZNCZ04LM #1449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@rytilahti can you merge this? |
Contributor
Author
|
I do not think the test failure is related |
rytilahti
approved these changes
Jul 8, 2022
Owner
rytilahti
left a comment
There was a problem hiding this comment.
Thanks! 👍 The 3.11-dev builds seems to be broken, at least at times, so that's not related to this. Let's merge it!
Codecov Report
@@ Coverage Diff @@
## master #1449 +/- ##
=======================================
Coverage 84.19% 84.19%
=======================================
Files 135 135
Lines 13449 13449
Branches 3216 3216
=======================================
Hits 11324 11324
Misses 1907 1907
Partials 218 218 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Owner
|
Could you please rebase on top of the current master, that should unblock merging (thanks to #1450)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue here: #1445