Get Route by Destination Address#20
Closed
ryansmick wants to merge 2 commits intorust-netlink:mainfrom
Closed
Conversation
Get a route by its destination address. This PR updates the RouteGetRequest to add a generic type for the IP address, and adds two new functions to accept IPv4 and IPv6 destination addresses for the destination address. It also updates the RouteHandle's get function to remove the IP family, as it's now specified by the v4 and v6 functions on the RouteGetRequest. The implemented functionality matches the functionality of the `ip route get` cli command.
Change usages of Vec::from() to .to_vec() to match style of other code in this project.
cathay4t
requested changes
Jul 10, 2023
Member
There was a problem hiding this comment.
This changes too many public API while you can avoid it by using
pub fn destination_address(&mut self) -> &mut self {
self.destination_address = Some(destination_address);
let octets = destination_address.octets().to_vec();
self.message.header.destination_prefix_length =
(octets.len() * 8) as u8;
self.message.nlas.push(Nla::Destination(octets));
self
}When patching a library, we should try our best to maintain API stability.
Member
|
Meanwhile, have you test your patch? My old code indicate |
Member
|
It has been a while with a lot code changed in this crate. Please rebase your code and open new pull request if you still want to work on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get a route by its destination address. This PR updates the
RouteGetRequestto add a generic type for the IP address, and adds two new functions to accept IPv4 and IPv6 addresses for the destination address. It also updates the RouteHandle's get function to remove the IP family, as it's now specified by thev4andv6functions on theRouteGetRequest. The implemented functionality matches the functionality of theip route getcli command.