Leave perf result comment on PRs after the post-merge perf run is completed#992
Merged
rylev merged 4 commits intorust-lang:masterfrom Sep 6, 2021
Merged
Leave perf result comment on PRs after the post-merge perf run is completed#992rylev merged 4 commits intorust-lang:masterfrom
rylev merged 4 commits intorust-lang:masterfrom
Conversation
Mark-Simulacrum
approved these changes
Sep 4, 2021
Member
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
Didn't review too closely, but I think this makes sense in broad strokes at least.
This was referenced Sep 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #711
This change makes it so that master commits are treated as "pull request builds" and enqueued in the
pull_request_buildtable which means that after the run completes a comment will be posted on the PR outlining the perf run result much like we currently do for try runs.This PR should be complete, but it's untested and the code is a bit messy. Reader beware.