Add new unstable API `downcast` to `std::io::Error` by NobodyXu · Pull Request #98387 · rust-lang/rust

NobodyXu · 2022-06-22T13:13:42Z

rust-lang/libs-team#57

Signed-off-by: Jiahao XU Jiahao_XU@outlook.com

that accepts `ErrorData<Box<Custom>>` Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

rust-highfive · 2022-06-22T13:13:45Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

rust-highfive · 2022-06-22T13:13:46Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon.

Please see the contribution instructions for more information.

NobodyXu · 2022-06-22T13:14:08Z

@rustbot label +T-libs-api -T-libs

thomcc

This looks okay to me, in terms of the impl (but needs API sign off of course)

library/std/src/io/error.rs

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

NobodyXu · 2022-06-23T03:11:37Z

Emmm, the CI failed at downloading some tools using curl...

joshtriplett · 2022-06-23T03:41:47Z

r? @yaahc

thomcc · 2022-06-23T05:37:20Z

@joshtriplett I wrote most of the current io::Error implementation (and I think @yaahc is on vacation), so I'm probably fine as an impl reviewer for this (unless this is part of the new process for API review?).

joshtriplett · 2022-06-23T08:02:54Z

@thomcc No problem; I just tend to bring error-related API review to @yaahc's attention.

NobodyXu · 2022-07-10T08:26:28Z

@thomcc Pinging this PR as it has been stale for 17 days.

yaahc · 2022-07-11T18:50:39Z

Reviewing now, thank you for the ping.

edit: left a comment on the ACP issue

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

rustbot · 2022-07-14T01:25:28Z

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

Stabilizing library features
Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
Changing public documentation in ways that create new stability guarantees
Changing observable runtime behavior of library APIs

yaahc

Should just need a tracking issue then it is good to go IMO. I have only one minor NIT comment that isn't a blocker.

library/std/src/io/error.rs

Co-authored-by: Jane Losare-Lusby <jlusby42@gmail.com>

NobodyXu · 2022-07-15T03:25:44Z

Should just need a tracking issue then it is good to go IMO. I have only one minor NIT comment that isn't a blocker.

I've added the tracking issue in #99262

library/std/src/io/error.rs

yaahc · 2022-07-15T20:18:06Z

looks great, thank you again!

@bors r+

bors · 2022-07-15T20:18:08Z

📌 Commit 8e8a3be has been approved by yaahc

It is now in the queue for this repository.

…owngrade_inner, r=yaahc Add new unstable API `downcast` to `std::io::Error` rust-lang/libs-team#57 Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

Rollup of 7 pull requests Successful merges: - rust-lang#98387 (Add new unstable API `downcast` to `std::io::Error`) - rust-lang#98662 (Add std::fs::write documentation precision) - rust-lang#99253 (Remove FIXME from MIR `always_storage_live_locals`) - rust-lang#99264 (Fix typo in mod.rs) - rust-lang#99270 (Add `#[must_use]` to `Box::from_raw`) - rust-lang#99277 (Stabilize `core::ffi::CStr`, `alloc::ffi::CString`, and friends) - rust-lang#99307 (Add regression test for rust-lang#64401) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup

NobodyXu added 4 commits June 22, 2022 22:01

Impl io::error::repr_unpacked::Repr::new

d11ff2a

that accepts `ErrorData<Box<Custom>>` Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

Impl io::error::repr_bitpacked::Repr::new

1713e25

that accepts `ErrorData<Box<Custom>>` Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

Add new unstable API Error::try_downgrade_inner

e0ea0c2

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

Add new unit test test_try_downcast_inner

d2211c9

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

rust-highfive assigned thomcc Jun 22, 2022

rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 22, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 22, 2022

rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 22, 2022

thomcc reviewed Jun 22, 2022

View reviewed changes

library/std/src/io/error.rs Outdated Show resolved Hide resolved

Use unwrap instead of unwrap_unchecked

516da4c

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

rust-highfive assigned yaahc and unassigned thomcc Jun 23, 2022

This comment has been minimized.

Sign in to view

Rename std::io::Error::try_downcast_inner to downcast

111253c

Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>

yaahc approved these changes Jul 14, 2022

View reviewed changes

library/std/src/io/error.rs Show resolved Hide resolved

Improve example of downcast

d8aba10

Co-authored-by: Jane Losare-Lusby <jlusby42@gmail.com>

NobodyXu changed the title ~~Add new unstable API try_downcast_inner to std::io::Error~~ Add new unstable API downcast to std::io::Error Jul 15, 2022

NobodyXu mentioned this pull request Jul 15, 2022

Tracking Issue for io_error_downcast #99262

Closed

5 tasks

yaahc reviewed Jul 15, 2022

View reviewed changes

library/std/src/io/error.rs Outdated Show resolved Hide resolved

Apply suggestions from code review

8e8a3be

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 15, 2022

JohnTitor mentioned this pull request Jul 16, 2022

Rollup of 7 pull requests #99305

Closed

JohnTitor mentioned this pull request Jul 16, 2022

Rollup of 7 pull requests #99315

Merged

bors merged commit bf9ed99 into rust-lang:master Jul 16, 2022

rustbot added this to the 1.64.0 milestone Jul 16, 2022

NobodyXu deleted the feature/std_io_Error_try_downgrade_inner branch July 17, 2022 01:54

Uh oh!

Conversation

NobodyXu commented Jun 22, 2022

Uh oh!

rust-highfive commented Jun 22, 2022

Uh oh!

rust-highfive commented Jun 22, 2022

Uh oh!

NobodyXu commented Jun 22, 2022

Uh oh!

thomcc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NobodyXu commented Jun 23, 2022

Uh oh!

joshtriplett commented Jun 23, 2022

Uh oh!

thomcc commented Jun 23, 2022

Uh oh!

This comment has been minimized.

joshtriplett commented Jun 23, 2022

Uh oh!

NobodyXu commented Jul 10, 2022

Uh oh!

yaahc commented Jul 11, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Jul 14, 2022

Uh oh!

yaahc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NobodyXu commented Jul 15, 2022

Uh oh!

Uh oh!

yaahc commented Jul 15, 2022

Uh oh!

bors commented Jul 15, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

yaahc commented Jul 11, 2022 •

edited

Loading