Merged
Conversation
Contributor
|
nikic
commented
Jan 27, 2021
Contributor
Author
There was a problem hiding this comment.
The NewPM support has turned into a big mess because there were major API changes in all of the recent releases. After the LLVM 12 upgrade, we should probably look into switching to NewPM by default (as clang will be doing so soon as well), and drop support for NewPM on older LLVM versions to reduce the mess.
Contributor
Author
There was a problem hiding this comment.
-Z split-dwarf=split no longer automatically implies that debuginfo is enabled. This is in line with changes in GCC and clang (https://reviews.llvm.org/D80391), though I'm not sure what changed to affect rustc (the referenced revision only affects the frontend).
Contributor
Author
|
@bors try @rust-timer queue |
Collaborator
|
Awaiting bors try build completion. |
Collaborator
|
⌛ Trying commit 9d6d477232c745d961b5610be3e0c2c22672b901 with merge dea4d1f65a5c24b55d88ff3ce5d3c78bab1b270d... |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
💔 Test failed - checks-actions |
Contributor
Author
|
After updating the python version, the next issue is a linker error: |
Member
|
The python3 thing will definitely need changes to the readme and possibly a relnotes tag. The |
Contributor
Author
|
Looks like using LLD as the linker instead avoids the error, so possibly it's a binutils linker bug? |
Member
|
That builder also uses a custom binutils, so that version could be updated if needed. |
Contributor
Author
|
@cuviper Just tried that, but updating to the latest binutils version didn't help. |
Contributor
|
Found similar error https://bugs.gentoo.org/760324 , solved with -fuse-ld=lld in LDFLAGS |
Contributor
Author
|
@bors try |
Collaborator
|
⌛ Trying commit 5b736302e6fdb2ddd3ec89fad263131d13255e70 with merge a40b38546f6f09e9b2a6592ef391c84f74ab536d... |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
💔 Test failed - checks-actions |
Contributor
Author
|
@bors try |
Collaborator
|
⌛ Trying commit 157e1062795b17758c9174c3925d366dc5e69199 with merge be3777f1a4bdb0417cca87d7c31d9fa85596bbad... |
Member
|
Yes, it does. |
This was referenced Mar 5, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the necessary adjustments to make rustc work with LLVM 12. I didn't encounter any major issues so far.
r? @cuviper