Skip to content

[WIP] Implement token-based handling of attributes#80689

Closed
Aaron1011 wants to merge 7 commits intorust-lang:masterfrom
Aaron1011:feature/new-preeexp-tts
Closed

[WIP] Implement token-based handling of attributes#80689
Aaron1011 wants to merge 7 commits intorust-lang:masterfrom
Aaron1011:feature/new-preeexp-tts

Conversation

@Aaron1011
Copy link
Contributor

Still needs some cleanup, opening for a preliminary perf run.

@rust-highfive
Copy link
Contributor

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 4, 2021
@Aaron1011
Copy link
Contributor Author

r? @ghost

@Aaron1011
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Collaborator

bors commented Jan 4, 2021

⌛ Trying commit 5e727f7b6211c00ff10c3e30fffd32c18256e968 with merge 5c23164c47aa9fef76aaf12c9208d3734277eedf...

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors

This comment has been minimized.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2021
@rust-log-analyzer

This comment has been minimized.

@Aaron1011
Copy link
Contributor Author

@bors try

@bors
Copy link
Collaborator

bors commented Jan 4, 2021

⌛ Trying commit 56295554ac24cd134a63951231028bd0e8392556 with merge d1b1f4501d48606232f1e44f2b76d126f68f3aea...

@Aaron1011
Copy link
Contributor Author

@rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Collaborator

bors commented Jan 4, 2021

☀️ Try build successful - checks-actions
Build commit: d1b1f4501d48606232f1e44f2b76d126f68f3aea (d1b1f4501d48606232f1e44f2b76d126f68f3aea)

@rust-timer
Copy link
Collaborator

Queued d1b1f4501d48606232f1e44f2b76d126f68f3aea with parent ab5b9ae, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jan 4, 2021
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (d1b1f4501d48606232f1e44f2b76d126f68f3aea): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jan 4, 2021
@Aaron1011
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Collaborator

bors commented Jan 5, 2021

⌛ Trying commit 7067bf03e7d3d17efa70f49ed7d4c49cc1690eb8 with merge e38d08da6180ca084747cc422341b0a81287b687...

@Aaron1011
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Collaborator

bors commented Feb 23, 2021

⌛ Trying commit 8b559123adb0a0bd2ca7125fa674c132d1792ba5 with merge c75d411ecc0bc7c763de15f780ea05da533c7e85...

@bors
Copy link
Collaborator

bors commented Feb 23, 2021

☀️ Try build successful - checks-actions
Build commit: c75d411ecc0bc7c763de15f780ea05da533c7e85 (c75d411ecc0bc7c763de15f780ea05da533c7e85)

@rust-timer
Copy link
Collaborator

Queued c75d411ecc0bc7c763de15f780ea05da533c7e85 with parent b02a619, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (c75d411ecc0bc7c763de15f780ea05da533c7e85): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@Aaron1011
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Collaborator

bors commented Feb 23, 2021

⌛ Trying commit 9264e1552a250cd4e6146510a1403755f6f36ffb with merge 661d708419d95b6566c3a05f8bae58bdc308672d...

@bors
Copy link
Collaborator

bors commented Feb 23, 2021

☀️ Try build successful - checks-actions
Build commit: 661d708419d95b6566c3a05f8bae58bdc308672d (661d708419d95b6566c3a05f8bae58bdc308672d)

@rust-timer
Copy link
Collaborator

Queued 661d708419d95b6566c3a05f8bae58bdc308672d with parent 446d453, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (661d708419d95b6566c3a05f8bae58bdc308672d): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@Aaron1011
Copy link
Contributor Author

Blocked on #82448

@Aaron1011
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Collaborator

bors commented Feb 27, 2021

⌛ Trying commit aeaa8b1 with merge 023bf1c81e0066f88abc33b1d53bf5fdd7ebd78b...

@bors
Copy link
Collaborator

bors commented Feb 27, 2021

☀️ Try build successful - checks-actions
Build commit: 023bf1c81e0066f88abc33b1d53bf5fdd7ebd78b (023bf1c81e0066f88abc33b1d53bf5fdd7ebd78b)

@rust-timer
Copy link
Collaborator

Queued 023bf1c81e0066f88abc33b1d53bf5fdd7ebd78b with parent 8e863eb, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (023bf1c81e0066f88abc33b1d53bf5fdd7ebd78b): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@Aaron1011
Copy link
Contributor Author

This thread has gotten enormous. Per @petrochenkov's suggestion, I've opened a new PR at #82608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-proc-macros Area: Procedural macros S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.