Stabilize std::path::Prefix::is_verbatim as const#76232
Closed
CDirkx wants to merge 3 commits intorust-lang:masterfrom
Closed
Stabilize std::path::Prefix::is_verbatim as const#76232CDirkx wants to merge 3 commits intorust-lang:masterfrom
std::path::Prefix::is_verbatim as const#76232CDirkx wants to merge 3 commits intorust-lang:masterfrom
Conversation
Insta-stabilize the method `std::path::Prefix::is_verbatim` as const. Also make private methods `is_drive` and `has_implicit_root` const. Possible because of the recent stabilization of const control flow. Also adds a test for `is_verbatim` in a const context.
Contributor
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
Of all the stabilizations tracked by #76225, this one has the weakest motivation; However, I also see no reason not to make this method const. |
6 tasks
|
r? @Amanieu |
Contributor
Author
|
Closing this as there is not enough motivation to const-stabilize this method on it's own. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Insta-stabilize the method
std::path::Prefix::is_verbatimas const, in the same way as PR#76198.Also make private methods
is_driveandhas_implicit_rootconst.Possible because of the recent stabilization of const control flow.
Part of #76225.