Set rustdoc --test files' path relative to the current directory by GuillaumeGomez · Pull Request #39859 · rust-lang/rust

GuillaumeGomez · 2017-02-15T21:47:44Z

r? @alexcrichton

alexcrichton · 2017-02-16T01:59:06Z

src/librustdoc/test.rs

This should use Path::strip_prefix if possible

Taking a look!

GuillaumeGomez · 2017-02-16T21:36:19Z

Updated.

alexcrichton · 2017-02-16T22:15:45Z

@bors: r+

bors · 2017-02-16T22:15:46Z

📌 Commit 047a215 has been approved by alexcrichton

@alexcrichton

…e-path, r=alexcrichton Set rustdoc --test files' path relative to the current directory r? @alexcrichton

GuillaumeGomez · 2017-02-17T11:27:11Z

@alexcrichton: On appveyor, the tests fail because the path look like this: src/abc\def\ghi\jkl. Why is there a / on windows? O.o

alexcrichton · 2017-02-17T15:28:02Z

@GuillaumeGomez yes, that's also a standard path separator on Windows

GuillaumeGomez · 2017-02-17T15:53:46Z

Sure, but it's a bit strange to have only one \ whereas there are only /. And I have no clue how to enforce the first or the other one to avoid test failure...

bors · 2017-02-18T07:17:10Z

⌛ Testing commit 047a215 with merge 27a715c...

bors · 2017-02-18T07:56:59Z

💔 Test failed - status-appveyor

GuillaumeGomez · 2017-02-19T15:32:01Z

@alexcrichton: So I forced paths to only use / in the compiletest. Does it seem ok to you?

GuillaumeGomez · 2017-02-20T22:32:20Z

cc @alexcrichton

alexcrichton · 2017-02-21T17:04:23Z

@bors: r+

bors · 2017-02-21T17:04:24Z

📌 Commit e606a43 has been approved by alexcrichton

bors · 2017-02-21T18:22:18Z

⌛ Testing commit e606a43 with merge 23ea668...

bors · 2017-02-21T19:17:59Z

💔 Test failed - status-appveyor

Rollup of 11 pull requests - Successful merges: #39859, #39886, #39892, #39903, #39914, #39918, #39988, #40010, #40027, #40030, #40035 - Failed merges:

@alexcrichton

…e-path, r=alexcrichton Set rustdoc --test files' path relative to the current directory r? @alexcrichton

bors · 2017-02-23T12:26:15Z

⌛ Testing commit 958fbc5 with merge ca17665...

bors · 2017-02-23T12:32:13Z

💔 Test failed - status-travis

alexcrichton · 2017-02-23T15:19:35Z

@bors: retry * network error

…

On Thu, Feb 23, 2017 at 6:32 AM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/204567584> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#39859 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95EVCCiyWFpNa088tYxohuLMb9Vmtks5rfXxPgaJpZM4MCSjR> .

bors · 2017-02-24T10:54:14Z

⌛ Testing commit 958fbc5 with merge f8e71ad...

bors · 2017-02-24T11:18:07Z

💔 Test failed - status-travis

alexcrichton · 2017-02-25T06:39:07Z

@bors: retry

empty logs?

@alexcrichton

…e-path, r=alexcrichton Set rustdoc --test files' path relative to the current directory r? @alexcrichton

bors · 2017-02-25T12:04:42Z

⌛ Testing commit 958fbc5 with merge d00e2cb...

@alexcrichton

…e-path, r=alexcrichton Set rustdoc --test files' path relative to the current directory r? @alexcrichton

bors · 2017-02-25T12:16:14Z

💔 Test failed - status-travis

eddyb · 2017-02-25T12:16:40Z

@bors retry

manually cancelled to prioritize rollup

bors · 2017-02-25T12:22:14Z

⌛ Testing commit 958fbc5 with merge 4e45a9d...

bors · 2017-02-25T12:29:29Z

💔 Test failed - status-travis

Rollup of 28 pull requests - Successful merges: #39859, #39864, #39888, #39903, #39905, #39914, #39945, #39950, #39953, #39961, #39980, #39988, #39993, #39995, #40019, #40020, #40022, #40024, #40025, #40026, #40027, #40031, #40035, #40037, #40038, #40064, #40069, #40086 - Failed merges: #39927, #40008, #40047

eddyb · 2017-02-25T12:29:54Z

@bors retry

manually cancelled to prioritize rollup

bors · 2017-02-25T15:00:32Z

⌛ Testing commit 958fbc5 with merge 1572bf1...

rust-highfive assigned alexcrichton Feb 15, 2017

alexcrichton reviewed Feb 16, 2017

View reviewed changes

Set rustdoc --test files' path relative to the current directory

047a215

GuillaumeGomez force-pushed the rustdoc-test-relative-path branch from 653b36d to 047a215 Compare February 16, 2017 21:35

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 17, 2017

Rollup merge of rust-lang#39859 - GuillaumeGomez:rustdoc-test-relativ…

f3d4c8c

…e-path, r=alexcrichton Set rustdoc --test files' path relative to the current directory r? @alexcrichton

frewsxcv mentioned this pull request Feb 17, 2017

Rollup of 9 pull requests #39895

Closed

GuillaumeGomez mentioned this pull request Feb 17, 2017

Rollup of 5 pull requests #39907

Closed

Fix rustdoc test with new file path

e606a43

GuillaumeGomez force-pushed the rustdoc-test-relative-path branch from b637b63 to e606a43 Compare February 20, 2017 00:12

Make path separator replacement for subfiles as well

958fbc5

bors added a commit that referenced this pull request Feb 23, 2017

Auto merge of #40045 - frewsxcv:rollup, r=frewsxcv

dd1c546

Rollup of 11 pull requests - Successful merges: #39859, #39886, #39892, #39903, #39914, #39918, #39988, #40010, #40027, #40030, #40035 - Failed merges:

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Feb 23, 2017

Rollup merge of rust-lang#39859 - GuillaumeGomez:rustdoc-test-relativ…

2282077

…e-path, r=alexcrichton Set rustdoc --test files' path relative to the current directory r? @alexcrichton

GuillaumeGomez mentioned this pull request Feb 23, 2017

Rollup of 6 pull requests #40053

Closed

eddyb added a commit to eddyb/rust that referenced this pull request Feb 25, 2017

Rollup merge of rust-lang#39859 - GuillaumeGomez:rustdoc-test-relativ…

49a9b93

…e-path, r=alexcrichton Set rustdoc --test files' path relative to the current directory r? @alexcrichton

eddyb mentioned this pull request Feb 25, 2017

Rollup of 29 pull requests #40089

Closed

eddyb added a commit to eddyb/rust that referenced this pull request Feb 25, 2017

Rollup merge of rust-lang#39859 - GuillaumeGomez:rustdoc-test-relativ…

46fed6e

…e-path, r=alexcrichton Set rustdoc --test files' path relative to the current directory r? @alexcrichton

eddyb mentioned this pull request Feb 25, 2017

Rollup of 28 pull requests #40091

Merged

bors merged commit 958fbc5 into rust-lang:master Feb 25, 2017

GuillaumeGomez deleted the rustdoc-test-relative-path branch February 27, 2017 16:12

Uh oh!

Conversation

GuillaumeGomez commented Feb 15, 2017

Uh oh!

alexcrichton Feb 16, 2017

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez Feb 16, 2017

Choose a reason for hiding this comment

Uh oh!

GuillaumeGomez commented Feb 16, 2017

Uh oh!

alexcrichton commented Feb 16, 2017

Uh oh!

bors commented Feb 16, 2017

Uh oh!

GuillaumeGomez commented Feb 17, 2017

Uh oh!

alexcrichton commented Feb 17, 2017

Uh oh!

GuillaumeGomez commented Feb 17, 2017

Uh oh!

bors commented Feb 18, 2017

Uh oh!

bors commented Feb 18, 2017

Uh oh!

GuillaumeGomez commented Feb 19, 2017

Uh oh!

GuillaumeGomez commented Feb 20, 2017

Uh oh!

alexcrichton commented Feb 21, 2017

Uh oh!

bors commented Feb 21, 2017

Uh oh!

bors commented Feb 21, 2017

Uh oh!

bors commented Feb 21, 2017

Uh oh!

bors commented Feb 23, 2017

Uh oh!

bors commented Feb 23, 2017

Uh oh!

alexcrichton commented Feb 23, 2017 via email

Uh oh!

bors commented Feb 24, 2017

Uh oh!

bors commented Feb 24, 2017

Uh oh!

alexcrichton commented Feb 25, 2017

Uh oh!

bors commented Feb 25, 2017

Uh oh!

bors commented Feb 25, 2017

Uh oh!

eddyb commented Feb 25, 2017

Uh oh!

bors commented Feb 25, 2017

Uh oh!

bors commented Feb 25, 2017

Uh oh!

eddyb commented Feb 25, 2017

Uh oh!

bors commented Feb 25, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants