Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with#153265
Conversation
|
r? @jhpratt rustbot has assigned @jhpratt. Use Why was this reviewer chosen?The reviewer was selected based on:
|
3652817 to
5d65c39
Compare
There was a problem hiding this comment.
In my opinion, this should be an extra commit on #152855 given that it is where discussion has taken place and it hasn't been merged yet.
I could also make this a standalone PR without Zakarumych's commit since his change doesn't actually affect the logical behavior of I'll try making a PR to Zakarumych's branch later today though! I'll keep this PR open however if it takes a while to push it into Zakarumych's branch. |
a4fed7f to
612930d
Compare
…tersperse_with regarding fused/non-fused iterators
612930d to
c8d343e
Compare
|
I decided to just remove Zakarumych's commit from this PR since I didn't see a way for me to add an extra commit to Zakarumych's PR; however, I've never done something like this and my assumption was that I could set the destination when creating another PR from this branch to Zakarumych's Rust fork If you know how I could add an extra commit to Zakarumych's PR, then I'll gladly try for that. Otherwise, I'm not certain about going down that route. This PR should still pass the tests as per the previous comment. |
|
My bad! I assumed without checking that the author of both PRs was the same. Thank you for the clarification 🙂 @bors r+ |
|
It's all good, mistakes happen 👍 |
…hpratt Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with This PR builds on top of rust-lang#152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.
…uwer Rollup of 12 pull requests Successful merges: - #152941 (prefer actual ABI-controling fields over target.abi when making ABI decisions) - #153227 (Don’t report missing fields in struct exprs with syntax errors.) - #153265 (Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with) - #152966 (Migrate 11 tests from tests/ui/issues to specific directories) - #153003 (rustdoc: make `--emit` and `--out-dir` mimic rustc) - #153034 (Remove unhelpful hint from trivial bound errors) - #153152 (Migration of LintDiagnostic - part 5) - #153177 (disable the ptr_fragment_in_final test on s390x) - #153221 (Add release notes for 1.94.0) - #153279 (feat: Provide an '.item_kind()' method on ItemEnum) - #153297 (Update the name of the Hermit operating system) - #153309 (Cleanup of c-variadic link test)
Rollup merge of #153265 - asder8215:intersperse_changes, r=jhpratt Clarified doc comments + added tests confirming current behavior for intersperse/intersperse_with This PR builds on top of #152855. I just added clarifying comments to `intersperse`/`intersperse_with` about its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests for `intersperse`/`intersperse_with`.
This PR builds on top of #152855. I just added clarifying comments to
intersperse/intersperse_withabout its guarantees for fused iterators (and how behavior for non-fused iterators are subject to change). I also added in tests for non-fused iterators demonstrating its current behavior; fused iterators are already tested for in existing tests forintersperse/intersperse_with.