sess: -Zbranch-protection is a target modifier#152909
Open
davidtwco wants to merge 1 commit intorust-lang:mainfrom
Open
sess: -Zbranch-protection is a target modifier#152909davidtwco wants to merge 1 commit intorust-lang:mainfrom
-Zbranch-protection is a target modifier#152909davidtwco wants to merge 1 commit intorust-lang:mainfrom
Conversation
`-Zbranch-protection` only makes sense if the entire crate graph has the option set, otherwise the security properties that branch protection provides won't be effective. This flag is unstable so I don't think this warrants an MCP.
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Member
|
I don't see a reason why we shouldn't compile the standard library with branch protection enabled to give users the ability to enable branch protection for their own executable without recompiling the standard library. There is no ABI constraint that prevents mixing. In fact hardware cfi extensions tend to use reuse instructions that were nops when cfi is disabled. An option would be to deny depending on libraries compiled without branch protection from a crate with it enabled, but not the other way around. Just like we do for mixing panic=abort and panic=unwind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Zbranch-protectiononly makes sense if the entire crate graph has the option set, otherwise the security properties that branch protection provides won't be effective - hence a target modifier. This flag is unstable so I don't think this warrants an MCP.