Fix incorrect let to const suggestion for pattern bindings#152834
Open
lapla-cogito wants to merge 1 commit intorust-lang:mainfrom
Open
Fix incorrect let to const suggestion for pattern bindings#152834lapla-cogito wants to merge 1 commit intorust-lang:mainfrom
let to const suggestion for pattern bindings#152834lapla-cogito wants to merge 1 commit intorust-lang:mainfrom
Conversation
Collaborator
|
r? @jackh726 rustbot has assigned @jackh726. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
cebca33 to
ccc0407
Compare
Kivooeo
reviewed
Feb 19, 2026
| @@ -1,3 +1,4 @@ | |||
| // ignore-tidy-filelength | |||
Contributor
Author
There was a problem hiding this comment.
The tidy test would fail without it (see the comment above by rust-log-analyzer). Since this directive is already used in other files, I didn’t think it would be an issue to use it here as well.
Contributor
Author
There was a problem hiding this comment.
If splitting the commit is more appropriate, I'll do so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a variable from a pattern binding was referenced inside a
const {}block, the compiler incorrectly suggested replacingletwithconst. This was reported in #152831 forif let, but also applies towhile letandlet ... else.close #152831