Refactor WriteBackendMethods a bit by bjorn3 · Pull Request #152801 · rust-lang/rust

bjorn3 · 2026-02-18T15:49:09Z

No description provided.

rustbot · 2026-02-18T15:49:13Z

Some changes occurred in compiler/rustc_codegen_gcc

rustbot · 2026-02-18T15:49:15Z

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Owners of files modified in this PR: compiler
compiler expanded to 68 candidates
Random selection from 15 candidates

bjorn3 · 2026-02-25T12:57:56Z

@rustbot ready

This also causes bitcode to be saved for the allocator shim with -Csave-temps.

rustbot · 2026-03-03T15:26:44Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

jackh726

One small comment.

In general, as I've said previously, it would be helpful to have some context on why these changes are being made - particularly because this is not an area I'm really familiar with.

View changes since this review

jackh726 · 2026-03-03T20:51:15Z

compiler/rustc_codegen_llvm/src/lib.rs

-            let _profiler = TimeTraceProfiler::new(time_trace);
-            f()
-        })
+    fn thread_profiler() -> Box<dyn Any> {


Why use Box<dyn Any>? I feel like it makes more sense to return TimeTraceProfiler, and then using Option<TimeTraceProfiler> at the call sites? Is there a reason that this needs to be on the heap?

TimeTraceProfiler is defined in cg_llvm, while thread_profiler is part of a trait defined in cg_ssa.

kk then it's fine as-is

kk then it's fine as-is

Does that count as an r=jackh726?

bjorn3 · 2026-03-03T21:12:46Z

In general, as I've said previously, it would be helpful to have some context on why these changes are being made - particularly because this is not an area I'm really familiar with.

As part of implementing rust-lang/compiler-team#908 I will have to move the LTO invocation from OngoingCodegen::join to the linker code (or perhaps slightly before it). To be able to do that, I think I may have to merge WriteBackendMethods into CodegenBackend or something like that (or maybe there could be a perform_lto method after join_codegen on CodegenBackend accepting a MaybeLtoModules?). To make this easier to do without issues for cg_clif (which doesn't use cg_ssa::write currently), I figured I would clean up WriteBackendMethods and move some things that can be moved out of OngoingCodegen::join already out of this method.

jackh726 · 2026-03-04T12:40:43Z

@bors r+

rust-bors · 2026-03-04T12:40:47Z

📌 Commit 6ea5244 has been approved by jackh726

It is now in the queue for this repository.

Refactor WriteBackendMethods a bit

Rollup of 9 pull requests Successful merges: - #152164 (Lint unused features) - #152801 (Refactor WriteBackendMethods a bit) - #153317 (Abort after `representability` errors) - #153361 (enable `PassMode::Indirect { on_stack: true, .. }` tail call arguments) - #153402 (miri subtree update) - #153276 (Remove `cycle_fatal` query modifier) - #153396 (use `minicore` in some `run-make` tests) - #153401 (Migrationg of `LintDiagnostic` - part 7) - #153406 (Remove a ping for myself)

…uwer Rollup of 12 pull requests Successful merges: - #153402 (miri subtree update) - #152164 (Lint unused features) - #152801 (Refactor WriteBackendMethods a bit) - #153196 (Update path separators to be available in const context) - #153204 (Add `#[must_use]` attribute to `HashMap` and `HashSet` constructors) - #153317 (Abort after `representability` errors) - #153276 (Remove `cycle_fatal` query modifier) - #153300 (Tweak some of our internal `#[rustc_*]` TEST attributes) - #153396 (use `minicore` in some `run-make` tests) - #153401 (Migrationg of `LintDiagnostic` - part 7) - #153406 (Remove a ping for myself) - #153414 (Rename translation -> formatting)

JonathanBrouwer · 2026-03-04T20:34:16Z

@bors try jobs=x86_64-gnu-distcheck
I think it's unlikely, but maybe the disk space failures in #153416 are caused by this PR?

Refactor WriteBackendMethods a bit try-job: x86_64-gnu-distcheck

rust-bors · 2026-03-04T22:54:17Z

☀️ Try build successful (CI)
Build commit: be27e73 (be27e7352d429afa3b2a01dcac47675bb314e9f2, parent: b90dc1e597db0bbc0cab0eccb39747b1a9d7e607)

…uwer Rollup of 12 pull requests Successful merges: - #153402 (miri subtree update) - #152164 (Lint unused features) - #152801 (Refactor WriteBackendMethods a bit) - #153196 (Update path separators to be available in const context) - #153204 (Add `#[must_use]` attribute to `HashMap` and `HashSet` constructors) - #153317 (Abort after `representability` errors) - #153276 (Remove `cycle_fatal` query modifier) - #153300 (Tweak some of our internal `#[rustc_*]` TEST attributes) - #153396 (use `minicore` in some `run-make` tests) - #153401 (Migrationg of `LintDiagnostic` - part 7) - #153406 (Remove a ping for myself) - #153414 (Rename translation -> formatting)

Rollup merge of #152801 - bjorn3:lto_refactors14, r=jackh726 Refactor WriteBackendMethods a bit

…uwer Rollup of 12 pull requests Successful merges: - rust-lang/rust#153402 (miri subtree update) - rust-lang/rust#152164 (Lint unused features) - rust-lang/rust#152801 (Refactor WriteBackendMethods a bit) - rust-lang/rust#153196 (Update path separators to be available in const context) - rust-lang/rust#153204 (Add `#[must_use]` attribute to `HashMap` and `HashSet` constructors) - rust-lang/rust#153317 (Abort after `representability` errors) - rust-lang/rust#153276 (Remove `cycle_fatal` query modifier) - rust-lang/rust#153300 (Tweak some of our internal `#[rustc_*]` TEST attributes) - rust-lang/rust#153396 (use `minicore` in some `run-make` tests) - rust-lang/rust#153401 (Migrationg of `LintDiagnostic` - part 7) - rust-lang/rust#153406 (Remove a ping for myself) - rust-lang/rust#153414 (Rename translation -> formatting)

bjorn3 added the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Feb 18, 2026

rustbot assigned jackh726 Feb 18, 2026

bjorn3 force-pushed the lto_refactors14 branch from 9866ca8 to 48187d1 Compare February 19, 2026 10:45

This comment has been minimized.

Sign in to view

bjorn3 force-pushed the lto_refactors14 branch from 48187d1 to 2bfa330 Compare February 24, 2026 09:29

This comment has been minimized.

Sign in to view

bjorn3 mentioned this pull request Feb 24, 2026

Move LTO from the codegen coordinator thread to link_binary rust-lang/compiler-team#908

Closed

13 tasks

bjorn3 removed the S-blocked Status: Blocked on something else such as an RFC or other implementation work. label Feb 25, 2026

bjorn3 added 5 commits March 3, 2026 15:24

Slightly simplify write_bitcode_to_file handling

dc3db23

This also causes bitcode to be saved for the allocator shim with -Csave-temps.

Replace spawn_named_thread method with thread_profiler

9e917ee

Move print_pass_timings and print_statistics calls to rustc_interface

22d4bb2

Fuse codegen into LTO optimize methods

eff0d4c

Move some methods to WriteBackendMethods

6ea5244

bjorn3 force-pushed the lto_refactors14 branch from 2bfa330 to 6ea5244 Compare March 3, 2026 15:26

jackh726 approved these changes Mar 3, 2026

View reviewed changes

jackh726 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 4, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 4, 2026

Rollup merge of rust-lang#152801 - bjorn3:lto_refactors14, r=jackh726

73f0cc7

Refactor WriteBackendMethods a bit

JonathanBrouwer mentioned this pull request Mar 4, 2026

Rollup of 6 pull requests #153403

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 4, 2026

Rollup merge of rust-lang#152801 - bjorn3:lto_refactors14, r=jackh726

3a74e86

Refactor WriteBackendMethods a bit

JonathanBrouwer mentioned this pull request Mar 4, 2026

Rollup of 7 pull requests #153404

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 4, 2026

Rollup merge of rust-lang#152801 - bjorn3:lto_refactors14, r=jackh726

82ee7b9

Refactor WriteBackendMethods a bit

JonathanBrouwer mentioned this pull request Mar 4, 2026

Rollup of 6 pull requests #153405

Closed

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Mar 4, 2026

Rollup merge of rust-lang#152801 - bjorn3:lto_refactors14, r=jackh726

9cdc51e

Refactor WriteBackendMethods a bit

GuillaumeGomez mentioned this pull request Mar 4, 2026

Rollup of 9 pull requests #153412

Closed

JonathanBrouwer mentioned this pull request Mar 4, 2026

Rollup of 12 pull requests #153416

Merged

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Mar 4, 2026

Auto merge of #152801 - bjorn3:lto_refactors14, r=<try>

be27e73

Refactor WriteBackendMethods a bit try-job: x86_64-gnu-distcheck

rust-bors bot merged commit 552b316 into rust-lang:main Mar 5, 2026
12 checks passed

rustbot added this to the 1.96.0 milestone Mar 5, 2026

rust-timer added a commit that referenced this pull request Mar 5, 2026

Unrolled build for #152801

da30d45

Rollup merge of #152801 - bjorn3:lto_refactors14, r=jackh726 Refactor WriteBackendMethods a bit

bjorn3 deleted the lto_refactors14 branch March 5, 2026 11:40

Uh oh!

Conversation

bjorn3 commented Feb 18, 2026

Uh oh!

rustbot commented Feb 18, 2026

Uh oh!

rustbot commented Feb 18, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

bjorn3 commented Feb 25, 2026

Uh oh!

rustbot commented Mar 3, 2026

Uh oh!

jackh726 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jackh726 Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

bjorn3 Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

jackh726 Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

bjorn3 Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bjorn3 commented Mar 3, 2026

Uh oh!

jackh726 commented Mar 4, 2026

Uh oh!

rust-bors bot commented Mar 4, 2026

Uh oh!

JonathanBrouwer commented Mar 4, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Mar 4, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jackh726 left a comment •

edited by rustbot

Loading

bjorn3 Mar 4, 2026 •

edited

Loading